completion_test: remove printing of stdout

Author: bzon

.gitignore

@@ -10,8 +10,9 @@ cookies.txt
 gitlabctl
 bin/
 
-# Test binary, build with `go test -c`
+# Test outputs, build with `go test -c`
 *.test
+testdocs
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out

cmd/.gitignore

@@ -1 +1,2 @@
 test_gencode*
+testdocs

cmd/completion_test.go

@@ -65,7 +65,6 @@ func TestCompletion(t *testing.T) {
 				noParent: true,
 			}
 			stdout, execResult := execT.executeCommand()
-			tInfo(stdout)
 			require.Equal(t, tc.expect, execResult,
 				printFlagsTable(tc.flagsMap, stdout))
 		})

cmd/codegen_test.go cmd/gencode_test.gocmd/codegen_test.go renamed to cmd/gencode_test.go

@@ -56,4 +56,7 @@ func TestGenCodeCmd(t *testing.T) {
 	if err := os.Remove("cmd/test_gencode_test.go"); err != nil {
 		glog.Fatal(err)
 	}
+
+	// ensure to go back
+	os.Chdir("cmd")
 }

cmd/gendoc.go

@@ -34,19 +34,19 @@ var gendocCmd = &cobra.Command{
 	Use:     "gendoc",
 	Aliases: []string{"gendocs", "docs"},
 	Short:   "Generate markdown documentation",
-	Run: func(cmd *cobra.Command, args []string) {
-		err := doc.GenMarkdownTree(rootCmd, docsDir)
-		if err != nil {
-			er(err)
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := doc.GenMarkdownTree(rootCmd, docsDir); err != nil {
+			return err
 		}
 		f, err := os.Create(docsDir + "/index.md")
 		if err != nil {
-			er(err)
+			return err
 		}
 		if err = doc.GenMarkdown(rootCmd, f); err != nil {
-			er(err)
+			return err
 		}
 		fmt.Printf("The documentations have been created in %s directory.\n", docsDir)
+		return nil
 	},
 }
 

cmd/gendoc_test.go

@@ -1,9 +1,20 @@
 package cmd
 
-import "testing"
+import (
+	"os"
+	"testing"
+
+	"github.com/golang/glog"
+)
 
 func TestGenDoc(t *testing.T) {
-	if _, err := executeCommand(rootCmd, "gendoc", "--dir=../docs"); err != nil {
+	cwd, err := os.Getwd()
+	if err != nil {
+		glog.Fatal(err)
+	}
+	docs := cwd + "/testdocs"
+	os.Mkdir(docs, 0755)
+	if _, err := executeCommand(rootCmd, "gendoc", "--dir="+docs); err != nil {
 		t.Fatal(err)
 	}
 }