Skip to content

Commit db74b07

Browse files
Luke Owlclaw2Luke Owlclaw2
authored andcommitted
Fixed tests
Fix: Handle Dictionary as implicit type
1 parent 92fa92d commit db74b07

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/TypeScriptDefinitionGenerator/Generator/IntellisenseWriter.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,10 @@ public static string WriteTypeScript(IEnumerable<IntellisenseObject> objects, st
7373
sbBody.AppendLine("{");
7474
WriteTSInterfaceDefinition(sbBody, prefixModule + "\t", io.Properties);
7575
sbBody.Append(prefixModule).AppendLine("}");
76-
// remember client-side references for which we need imports
77-
neededImports.AddRange(io.Properties.Where(p => p.Type.ClientSideReferenceName != null)
78-
.Select(p => p.Type.ClientSideReferenceName));
76+
// Remember client-side references for which we need imports.
77+
// Dictionary are built-in into TS, they need no imports.
78+
neededImports.AddRange(io.Properties.Where(p => p.Type.ClientSideReferenceName != null &&
79+
!p.Type.IsDictionary).Select(p => p.Type.ClientSideReferenceName));
7980
}
8081
}
8182

tests/ClassLibrary1/ClassLibrary1.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
</PropertyGroup>
66

77
<ItemGroup>
8-
<None Update="Some.generated.ts">
9-
<DependentUpon>Some.cs</DependentUpon>
8+
<None Update="SomeEnum.generated.ts">
9+
<DependentUpon>SomeEnum.cs</DependentUpon>
1010
</None>
1111
<None Update="SomeClass.generated.ts">
1212
<DependentUpon>SomeClass.cs</DependentUpon>

tests/TypeScriptDefinitionGenerator.Tests/IntellisenseParserTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ public void _ShouldWorkProperly2()
156156
"// This file was generated by TypeScript Definition Generator v2.2.0.0\n" +
157157
"// </auto-generated>\n" +
158158
"// ------------------------------------------------------------------------------\n" +
159+
"import { SomeEnum } from \"./SomeEnum.generated\";\n" +
159160
"export interface SomeClass {\n" +
160161
" inc1: number;\n" +
161162
" some: SomeEnum;\n" +

0 commit comments

Comments
 (0)