fix: IDFA trigger at configure time (segmentio#925)

Author: oscb

packages/core/src/analytics.ts

@@ -426,8 +426,6 @@ export class SegmentClient {
   async process(incomingEvent: SegmentEvent) {
     const event = this.applyRawEventData(incomingEvent);
 
-    console.log(`Process: ${this.isReady.value}`);
-
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -479,9 +477,6 @@ export class SegmentClient {
    * @param isReady
    */
   private async onReady() {
-    console.log(
-      `onReady, pendingEvents=${this.store.pendingEvents.get().length}`
-    );
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;

packages/core/src/storage/__tests__/sovranStorage.test.ts

@@ -135,7 +135,6 @@ describe('sovranStorage', () => {
 
   it('adds/removes pending events', async () => {
     const sovran = new SovranStorage({ storeId: 'test' });
-    console.log(sovran.pendingEvents.get());
 
     // expect(sovran.pendingEvents.get().length).toBe(0);
 

packages/plugins/plugin-idfa/src/IdfaPlugin.tsx

@@ -2,10 +2,12 @@ import {
   ErrorType,
   Plugin,
   PluginType,
+  SegmentClient,
   SegmentError,
 } from '@segment/analytics-react-native';
 import type { IdfaData } from './types';
 import { AnalyticsReactNativePluginIdfa } from './AnalyticsReactNativePluginIdfa';
+import { Platform } from 'react-native';
 
 const { getTrackingAuthorizationStatus } = AnalyticsReactNativePluginIdfa;
 
@@ -20,10 +22,20 @@ const { getTrackingAuthorizationStatus } = AnalyticsReactNativePluginIdfa;
 export class IdfaPlugin extends Plugin {
   type = PluginType.enrichment;
 
+  private shouldAskPermission = true;
+
   constructor(shouldAskPermission = true) {
     super();
+    this.shouldAskPermission = shouldAskPermission;
+  }
+
+  configure(analytics: SegmentClient): void {
+    this.analytics = analytics;
+    if (Platform.OS !== 'ios') {
+      return;
+    }
 
-    if (shouldAskPermission === true) {
+    if (this.shouldAskPermission === true) {
       this.getTrackingStatus();
     }
   }