Fix Go Report Card issues

- Remove unused showPolicies variable
- Replace deprecated tls.VersionSSL30 with raw value 0x0300
- Fix potential nil pointer dereference in test by using t.Fatal

Author: thebenignhacker

cmd/tlsanalyzer/main.go

@@ -41,7 +41,6 @@ var (
 	policyFile   string
 	targetsFile  string
 	concurrency  int
-	showPolicies bool
 )
 
 func main() {

internal/scanner/scanner.go

@@ -45,7 +45,7 @@ func DefaultConfig() *Config {
 		SkipCertVerify: true, // We're analyzing, not validating
 		CheckVulns:     true,
 		CheckQuantum:   true,
-		MinTLSVersion:  tls.VersionSSL30,
+		MinTLSVersion:  0x0300, // SSL 3.0 - needed to detect insecure configurations
 		MaxTLSVersion:  tls.VersionTLS13,
 	}
 }
@@ -441,7 +441,7 @@ func tlsVersionName(v uint16) string {
 		return "TLS 1.1"
 	case tls.VersionTLS10:
 		return "TLS 1.0"
-	case tls.VersionSSL30:
+	case 0x0300: // SSL 3.0
 		return "SSL 3.0"
 	default:
 		return fmt.Sprintf("0x%04X", v)

internal/scanner/scanner_test.go

@@ -29,7 +29,7 @@ func TestNew(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			s := New(tt.config)
 			if s == nil {
-				t.Error("New returned nil")
+				t.Fatal("New returned nil")
 			}
 			if s.config == nil {
 				t.Error("Scanner config is nil")