Add environment variables to pre-uninstall script (#1206)

* Increase test verbosity

* DEBUG: only test conda-standalone uninstallation

* Flip skip conditional

* Move installer creation after file setup

* Move .conda assert statement to after the installation

* DEBUG: check user files directory along the way

* Add script env variables to Windows uninstaller

* Make macOS spelling consistent

* Revert "DEBUG: only test conda-standalone uninstallation"

This reverts commit 79eada3.

* Add news

* Apply suggestions from code review

Co-authored-by: Robin <34315751+lrandersson@users.noreply.github.com>

---------

Co-authored-by: Robin <34315751+lrandersson@users.noreply.github.com>

Author: marcoesters

.github/workflows/main.yml

@@ -138,7 +138,7 @@ jobs:
         run: conda config --show-sources
       - name: Run unit tests
         run: |
-          pytest -vv --cov=constructor --cov-branch tests/ -m "not examples"
+          pytest -ra -vvv --cov=constructor --cov-branch tests/ -m "not examples"
           coverage run --branch --append -m constructor -V
           coverage json
       - uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
@@ -156,7 +156,7 @@ jobs:
           CONSTRUCTOR_SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.26100.0/x86/signtool.exe"
         run: |
           rm -rf coverage.json
-          pytest -vv --cov=constructor --cov-branch tests/test_examples.py
+          pytest -ra -vvv --cov=constructor --cov-branch tests/test_examples.py
           coverage run --branch --append -m constructor -V
           coverage json
       - uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0

constructor/nsis/main.nsi.tmpl

@@ -1822,6 +1822,9 @@ Section "Uninstall"
     ${Else}
         System::Call 'kernel32::SetEnvironmentVariable(t,t)i("INSTALLER_UNATTENDED", "0")'
     ${EndIf}
+{%- for key, escaped_val in SCRIPT_ENV_VARIABLES | items %}
+    System::Call 'kernel32::SetEnvironmentVariable(t,t)i("{{ key }}", {{ escaped_val }})'
+{%- endfor %}
 
 {%- if uninstall_with_conda_exe %}
     # Parse uninstall options

news/1206-add-env-to-pre-uininstall

@@ -0,0 +1,19 @@
+### Enhancements
+
+* EXE: Add script environment variables to pre-uninstall scripts. (#1206)
+
+### Bug fixes
+
+* <news item>
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

tests/test_examples.py

@@ -928,7 +928,7 @@ def test_register_envs(tmp_path, request):
         assert str(install_dir) not in environments_txt
 
 
-@pytest.mark.skipif(sys.platform != "darwin", reason="MacOS only")
+@pytest.mark.skipif(sys.platform != "darwin", reason="macOS only")
 @pytest.mark.parametrize("domains", ({}, {"enable_anywhere": "false", "enable_localSystem": True}))
 def test_pkg_distribution_domains(tmp_path, domains):
     recipe_path = _example_path("osxpkg")
@@ -1326,8 +1326,9 @@ def test_ignore_condarc_files(tmp_path, monkeypatch, request):
 
 
 @pytest.mark.skipif(
-    CONDA_EXE == StandaloneExe.CONDA and check_version(CONDA_EXE_VERSION, min_version="24.11.0"),
-    reason="Requires conda-standalone 24.11.x or newer",
+    CONDA_EXE == StandaloneExe.CONDA
+    and not check_version(CONDA_EXE_VERSION, min_version="24.11.0"),
+    reason=f"Requires conda-standalone 24.11.x or newer (is {CONDA_EXE_VERSION})",
 )
 @pytest.mark.skipif(not sys.platform == "win32", reason="Windows only")
 @pytest.mark.skipif(not ON_CI, reason="CI only - Interacts with system files")
@@ -1347,26 +1348,13 @@ def test_uninstallation_standalone(
     remove_config_files: str | None,
     tmp_path: Path,
 ):
-    yaml = YAML()
     recipe_path = _example_path("uninstall_with_conda_exe")
     input_path = tmp_path / "input"
     shutil.copytree(str(recipe_path), str(input_path))
 
-    installer, install_dir = next(create_installer(input_path, tmp_path))
-    monkeypatch.setenv("USERPROFILE", str(tmp_path))
-    _run_installer(
-        input_path,
-        installer,
-        install_dir,
-        check_subprocess=True,
-        uninstall=False,
-    )
-
     # Set up files for removal.
     # Since conda-standalone is extensively tested upstream,
     # only set up a minimum set of files.
-    dot_conda_dir = tmp_path / ".conda"
-    assert dot_conda_dir.exists()
 
     # Minimum set of files needed for an index cache
     pkg_cache = tmp_path / "pkgs"
@@ -1404,13 +1392,28 @@ def test_uninstallation_standalone(
     for file in user_files:
         (user_files_dir / file).touch()
         assert (user_files_dir / file).exists()
+    yaml = YAML()
     construct_yaml_file = input_path / "construct.yaml"
     with construct_yaml_file.open() as file:
         construct_yaml = yaml.load(file)
     construct_yaml["script_env_variables"] = {"USER_FILES": str(user_files_dir)}
     with construct_yaml_file.open(mode="w") as file:
         yaml.dump(construct_yaml, file)
 
+    installer, install_dir = next(create_installer(input_path, tmp_path))
+    monkeypatch.setenv("USERPROFILE", str(tmp_path))
+    _run_installer(
+        input_path,
+        installer,
+        install_dir,
+        check_subprocess=True,
+        uninstall=False,
+    )
+
+    # Ensure that the installation has set up environments.txt
+    dot_conda_dir = tmp_path / ".conda"
+    assert dot_conda_dir.exists()
+
     try:
         _run_uninstaller_exe(install_dir, check=True, options=uninstall_options)
         assert dot_conda_dir.exists() != remove_user_data