Fix Implicitly nullable markings (#43)

Author: koertho

src/Finder/SourceFinder.php

@@ -56,7 +56,7 @@ public function findMultiple(SourceCriteria $criteria): array
      *
      * @throws \RuntimeException
      */
-    public function findRelatedSourceRecords(SourceCriteria $criteria, int $limit = null): array
+    public function findRelatedSourceRecords(SourceCriteria $criteria, ?int $limit = null): array
     {
         if (0 === \count($criteria->getIds())) {
             throw new \RuntimeException('No IDs have been provided');

src/Finder/TagFinder.php

@@ -89,7 +89,7 @@ public function findMultiple(TagCriteria $criteria): array
     /**
      * Get the top tags. The tag count will be part of tag's data ($tag->getData()['count']).
      */
-    public function getTopTags(TagCriteria $criteria, int $limit = null, bool $withCount = false): array
+    public function getTopTags(TagCriteria $criteria, ?int $limit = null, bool $withCount = false): array
     {
         if (0 === \count($tagIds = $this->getTopTagIds($criteria, $limit, $withCount))) {
             return [];
@@ -111,7 +111,7 @@ public function getTopTags(TagCriteria $criteria, int $limit = null, bool $withC
     /**
      * Get the top tag IDs.
      */
-    public function getTopTagIds(TagCriteria $criteria, int $limit = null, bool $withCount = false): array
+    public function getTopTagIds(TagCriteria $criteria, ?int $limit = null, bool $withCount = false): array
     {
         // No array_unique() here!
         $tagIds = DcaRelationsModel::getRelatedValues($criteria->getSourceTable(), $criteria->getSourceField(), $criteria->getSourceIds());

src/Manager/DefaultManager.php

@@ -71,15 +71,15 @@ public function setSourceFinder(SourceFinder $sourceFinder): void
     /**
      * {@inheritdoc}
      */
-    public function getAllTags(string $source = null): array
+    public function getAllTags(?string $source = null): array
     {
         return $this->tagFinder->findMultiple($this->createTagCriteria($source));
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getFilteredTags(array $values, string $source = null): array
+    public function getFilteredTags(array $values, ?string $source = null): array
     {
         $criteria = $this->createTagCriteria($source);
         $criteria->setValues(\count($values) ? $values : [0]);
@@ -203,7 +203,7 @@ public function getSourceRecordsCount(array $data, DataContainer $dc): int
     /**
      * {@inheritdoc}
      */
-    public function getTopTagIds(string $source = null): array
+    public function getTopTagIds(?string $source = null): array
     {
         $ids = [];
         $sources = (null !== $source) ? [$source] : $this->sources;
@@ -259,7 +259,7 @@ public function getTagFinder(): TagFinder
     /**
      * Create the tag criteria.
      */
-    public function createTagCriteria(string $source = null): TagCriteria
+    public function createTagCriteria(?string $source = null): TagCriteria
     {
         return new TagCriteria($this->name, $this->getSource($source));
     }
@@ -275,15 +275,15 @@ public function getSourceFinder(): SourceFinder
     /**
      * Create the source criteria.
      */
-    public function createSourceCriteria(string $source = null): SourceCriteria
+    public function createSourceCriteria(?string $source = null): SourceCriteria
     {
         return new SourceCriteria($this->name, $this->getSource($source));
     }
 
     /**
      * Get the source.
      */
-    protected function getSource(string $source = null): string
+    protected function getSource(?string $source = null): string
     {
         if (null === $source) {
             $source = $this->sources[0];
@@ -297,7 +297,7 @@ protected function getSource(string $source = null): string
     /**
      * Generate the tag alias.
      */
-    protected function generateAlias(TagModel $model, string $source = null): void
+    protected function generateAlias(TagModel $model, ?string $source = null): void
     {
         $alias = StringUtil::generateAlias($model->name);
 

src/Manager/ManagerInterface.php

@@ -17,10 +17,10 @@ interface ManagerInterface
     /**
      * Get all tags.
      */
-    public function getAllTags(string $source = null): array;
+    public function getAllTags(?string $source = null): array;
 
     /**
      * Get tags optionally filtered by values.
      */
-    public function getFilteredTags(array $values, string $source = null): array;
+    public function getFilteredTags(array $values, ?string $source = null): array;
 }

tests/Fixtures/DummyManager.php

@@ -44,15 +44,15 @@ public function getSourceRecordsCount(array $data, DataContainer $dc): int
     /**
      * @inheritDoc
      */
-    public function getAllTags(string $source = null): array
+    public function getAllTags(?string $source = null): array
     {
         return [];
     }
 
     /**
      * @inheritDoc
      */
-    public function getFilteredTags(array $values, string $source = null): array
+    public function getFilteredTags(array $values, ?string $source = null): array
     {
         return [];
     }