Fix the unit tests

Author: qzminski

composer.json

@@ -52,5 +52,8 @@
             "php-http/discovery": true,
             "terminal42/contao-build-tools": true
         }
+    },
+    "scripts": {
+        "unit-tests": "@php vendor/bin/phpunit"
     }
 }

tests/DependencyInjection/CodefogTagsExtensionTest.php

@@ -39,7 +39,6 @@ public function testLoad(): void
         );
 
         // Listeners
-        $this->assertTrue($container->hasDefinition('codefog_tags.listener.insert_tags'));
         $this->assertTrue($container->hasDefinition('codefog_tags.listener.tag_manager'));
         $this->assertTrue($container->hasDefinition('codefog_tags.listener.data_container.tag'));
 

tests/EventListener/AddAssetsListenerTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Codefog\TagsBundle\Test\EventListener;
+
+use Codefog\TagsBundle\EventListener\AddAssetsListener;
+use Contao\CoreBundle\Routing\ScopeMatcher;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Asset\Packages;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
+
+final class AddAssetsListenerTest extends TestCase
+{
+    public function testInvoke(): void
+    {
+        $GLOBALS['TL_CSS'] = [];
+        $GLOBALS['TL_JAVASCRIPT'] = [];
+
+        $this->mockListener()();
+
+        $this->assertContains('bundles/codefog_tags/tags-widget.css', $GLOBALS['TL_CSS']);
+        $this->assertContains('bundles/codefog_tags/tags-widget.js', $GLOBALS['TL_JAVASCRIPT']);
+    }
+
+    private function mockListener(): AddAssetsListener
+    {
+        $packages = $this->createMock(Packages::class);
+        $packages
+            ->method('getUrl')
+            ->willReturnCallback(static function (string $path, string $packageName) {
+                return sprintf('bundles/%s/%s', $packageName, $path);
+            })
+        ;
+
+        $requestStack = $this->createConfiguredMock(RequestStack::class, [
+            'getCurrentRequest' => new Request(),
+        ]);
+
+        $scopeMatcher = $this->createConfiguredMock(ScopeMatcher::class, [
+            'isBackendRequest' => true,
+        ]);
+
+        return new AddAssetsListener($packages, $requestStack, $scopeMatcher);
+    }
+}

tests/EventListener/TagManagerListenerTest.php

@@ -8,11 +8,8 @@
 use Codefog\TagsBundle\Manager\ManagerInterface;
 use Codefog\TagsBundle\ManagerRegistry;
 use Codefog\TagsBundle\Test\Fixtures\DummyManager;
-use Contao\CoreBundle\Routing\ScopeMatcher;
 use Contao\DataContainer;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\RequestStack;
 
 final class TagManagerListenerTest extends TestCase
 {
@@ -28,8 +25,6 @@ public function testOnLoadDataContainer(): void
             ],
         ];
 
-        $GLOBALS['TL_CSS'] = [];
-        $GLOBALS['TL_JAVASCRIPT'] = [];
         $GLOBALS['TL_CONFIG']['debugMode'] = false;
 
         $this->mockListener()->onLoadDataContainer('tl_table');
@@ -47,13 +42,6 @@ public function testOnLoadDataContainer(): void
             ],
             $GLOBALS['TL_DCA']['tl_table']['fields'],
         );
-
-        $this->assertContains('bundles/codefogtags/selectize.min.css', $GLOBALS['TL_CSS']);
-        $this->assertContains('bundles/codefogtags/backend.min.css', $GLOBALS['TL_CSS']);
-        $this->assertContains('assets/jquery/js/jquery.min.js', $GLOBALS['TL_JAVASCRIPT']);
-        $this->assertContains('bundles/codefogtags/selectize.min.js', $GLOBALS['TL_JAVASCRIPT']);
-        $this->assertContains('bundles/codefogtags/widget.min.js', $GLOBALS['TL_JAVASCRIPT']);
-        $this->assertContains('bundles/codefogtags/backend.min.js', $GLOBALS['TL_JAVASCRIPT']);
     }
 
     public function testOnLoadDataContainerNoFields(): void
@@ -66,15 +54,7 @@ public function testOnLoadDataContainerNoFields(): void
             ->willReturn(new DummyManager())
         ;
 
-        $requestStack = $this->createConfiguredMock(RequestStack::class, [
-            'getCurrentRequest' => new Request(),
-        ]);
-
-        $scopeMatcher = $this->createConfiguredMock(ScopeMatcher::class, [
-            'isBackendRequest' => true,
-        ]);
-
-        $listener = new TagManagerListener($registry, $requestStack, $scopeMatcher);
+        $listener = new TagManagerListener($registry);
         $listener->onLoadDataContainer('tl_table');
 
         $this->assertSame([], $GLOBALS['TL_DCA']['tl_table']);
@@ -90,7 +70,6 @@ public function testOnFieldSaveCallback(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],
@@ -111,7 +90,6 @@ public function testOnFieldSaveCallbackManagerUnsupported(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],
@@ -134,7 +112,6 @@ public function testOnOptionsCallback(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],
@@ -155,7 +132,6 @@ public function testOnOptionsCallbackManagerUnsupported(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],
@@ -174,14 +150,6 @@ private function mockListener($manager = null): TagManagerListener
             'get' => $manager ?? new DummyManager(),
         ]);
 
-        $requestStack = $this->createConfiguredMock(RequestStack::class, [
-            'getCurrentRequest' => new Request(),
-        ]);
-
-        $scopeMatcher = $this->createConfiguredMock(ScopeMatcher::class, [
-            'isBackendRequest' => true,
-        ]);
-
-        return new TagManagerListener($registry, $requestStack, $scopeMatcher);
+        return new TagManagerListener($registry);
     }
 }

tests/Manager/DefaultManagerTest.php

@@ -142,7 +142,6 @@ public function testGetFilterOptionsWithPredefinedTagsSource(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],
@@ -183,7 +182,6 @@ public function testGetSourceRecordsCountWithPredefinedTagsSource(): void
 
         $dataContainer = $this->createMock(DataContainer::class);
         $dataContainer
-            ->expects($this->exactly(2))
             ->method('__get')
             ->willReturnMap([
                 ['table', 'tl_table'],