Raise instead of throw.

Author: Amir Tocker

lib/cloudinary/auth_token.rb

@@ -12,20 +12,20 @@ module AuthToken
 
     def self.generate(options = {})
       key = options[:key]
-      throw "Missing auth token key configuration" unless key
-        name = options[:token_name] || "__cld_token__"
-        start = options[:start_time]
-        expiration = options[:expiration]
-        ip = options[:ip]
-        acl = options[:acl]
-        duration = options[:duration]
-        url = options[:url]
+      raise "Missing auth token key configuration" unless key
+      name = options[:token_name] || "__cld_token__"
+      start = options[:start_time]
+      expiration = options[:expiration]
+      ip = options[:ip]
+      acl = options[:acl]
+      duration = options[:duration]
+      url = options[:url]
       start = Time.new.getgm.to_i if start == 'now'
       if expiration.nil? || expiration == 0
         if !(duration.nil? || duration == 0)
           expiration = (start || Time.new.getgm.to_i) + duration
         else
-          throw 'Must provide either expiration or duration'
+          raise 'Must provide either expiration or duration'
         end
       end
 

spec/auth_token_spec.rb

@@ -58,9 +58,14 @@
       expect(url).to eq("http://test123-res.cloudinary.com/image/authenticated/v1486020273/sample.jpg?__cld_token__=st=11111111~exp=11111411~hmac=8db0d753ee7bbb9e2eaf8698ca3797436ba4c20e31f44527e43b6a6e995cfdb3")
 
     end
-    it "should throw if expiration and duration are not provided" do
+    it "should raise if key is not provided" do
+      Cloudinary.config.auth_token[:key] = nil
+      token = { :expiration => 111111, :duration => 0 }
+      expect{Cloudinary::Utils.generate_auth_token(token)}.to raise_error
+    end
+    it "should raise if expiration and duration are not provided" do
       token = { :key => KEY, :expiration => 0, :duration => 0 }
-      expect{Cloudinary::Utils.generate_auth_token(token)}.to raise_exception
+      expect{Cloudinary::Utils.generate_auth_token(token)}.to raise_error
     end
   end
   describe "authentication token" do