riscv64 system registers missing from riscv_reg

[hainest]

As an example the instruction csrw mstatus, ra is correctly decoded, but the system register representations are not in include/capstone/riscv.h. This makes it impossible to identify the system register in user code.

I poked around in the importer, but could quite figure out what was missing to make this happen. My guess is that GET_ENUM_VALUES_SysReg from RISCVGenCSSystemOperandsEnum.inc needs to be defined.

$ ./cstool -dar riscv64 73900030

 0  73 90 00 30  csrw	mstatus, ra
	ID: 189 (csrrw)
	Is alias: 0 (invalid) with REAL operand set
	op_count: 3
		operands[0].type: REG = zero
		operands[0].access: WRITE
		operands[1].type: CSR = mstatus
		operands[1].access: READ | WRITE
		operands[2].type: REG = ra
		operands[2].access: READ

---

Questions	Answers
System Capstone runs on OS/arch/bits	Ubuntu x86_64
Capstone module affected	riscv
Source of Capstone	git clone
Version/git commit	4ab9943

[Rot127]

cc @moste00

[Rot127]

As you correctly discovered are the system registers defined within GET_ENUM_VALUES_SysReg.
The way to include them into the riscv.h header is by adding a new enum of of the form:

typedef enum riscv_sys_reg {
	// generated content <RISCVGenCSSystemOperandsEnum.inc:GET_ENUM_VALUES_SysReg> begin
	// clang-format off

	// clang-format on
	// generated content <RISCVGenCSSystemOperandsEnum.inc:GET_ENUM_VALUES_SysReg> end
} cs_riscv_sysreg;

Then run ASUpdater -s PatchArchHeader (assuming the files are already generated and all).

[moste00]

Thank you for reporting it. I'm on this.

[hainest]

Thank you for reporting it. I'm on this.

Thanks for helping out. I started to use the updater, but my local LLVM install needs a bunch of updates. I'll still go through the steps and see if I get the same result as you (if you post a PR).

[Rot127]

but my local LLVM install needs a bunch of updates. I'll still go through the steps and see if I get the same result as you (if you post a PR).

Do you use our Auto-Sync fork? https://github.com/capstone-engine/llvm-capstone/

[hainest]

but my local LLVM install needs a bunch of updates. I'll still go through the steps and see if I get the same result as you (if you post a PR).

Do you use our Auto-Sync fork? https://github.com/capstone-engine/llvm-capstone/

I am. I was getting merge conflicts because I had stupidly made some changes on the main branch a long time ago. It's a quick fix. I just haven't gotten back to it yet.