[Bug] The workflow_dispatch trigger does not work

[steebchen]

Describe the bug

I don't understand how I can run the workflow manually. In the readme it says I can trigger it and it also defines the workflow_dispatch even. However, when I try to trigger the workflow manually, it just gets skipped. I tried to remove the skip but then the workflow itself returns an error: Error: This action only runs for pushes to PRs. So how can I manually trigger it for all existing images? As I have a bunch of images in my repo already.

How To Reproduce

https://github.com/theopenco/llmgateway/actions/workflows/calibreapp-image-actions.yml

Screenshots

No response

Relevant Log Output

Code of Conduct

• I agree to follow this project’s Code of Conduct

[benschwarz]

Hey @steebchen, good catch. I added this workflow run when I released the recent updates to image-actions, but in the midst of all the changes I forgot to finalise the workflow_dispatch.

It should work, but we'll need an update the event handling in entrypoint.js to include the workflow_dispatch event type, and the likely the event payload.action also:

image-actions/entrypoint.ts

Lines 9 to 27 in 05b1cf4

	const main = async () => {
	if (!COMPRESS_ONLY) {
	// Bail out if the event that executed the action wasn’t a pull_request
	if (GITHUB_EVENT_NAME !== 'pull_request') {
	core.error('This action only runs for pushes to PRs')
	process.exit(78)
	}
	// Bail out if the pull_request event wasn't synchronize or opened
	if (
	context.payload.action !== 'synchronize' &&
	context.payload.action !== 'opened'
	) {
	core.error(
	`Check run has action ${context.payload.action}. Wants: synchronize or opened`
	)
	process.exit(0)
	}
	}

If someone wants to pick this up, I'll be happy to review and help get it released.

[steebchen]

@benschwarz

via #367

I skipped the PR comment for now because the workflow_dispatch doesn't have a PR context, ideally this would be still done somehow but I think this is good for now