Replace the tab entries on first load (#3041)

Author: jameskerr

apps/zui/src/models/browser-tab.ts

@@ -38,7 +38,18 @@ export class BrowserTab extends DomainModel<Attrs> {
     if (this.history.location.pathname === pathname) {
       this.history.replace(pathname)
     } else {
+      // Whenever a tab is created it constructs itself with a root entry "/".
+      // This can mess up the tab history back button, allowing the user to
+      // get back to this "root" url which does not contain forward/back buttons.
+      // Instead, this if statement resets the entries and index for this tab
+      // if the only url in the entries array is "/", making it the
+      // first entry in the history the first pathname given to browerTab.load()
+      if (this.history.length == 1 && this.history.location.pathname === "/") {
+        this.history.entries = []
+        this.history.index = -1
+      }
       this.history.push(pathname)
+      console.log(this.history)
     }
   }
 

packages/zui-player/tests/queries.spec.ts

@@ -15,6 +15,11 @@ test.describe('Query tests', () => {
     await app.shutdown();
   });
 
+  test('session initializes with the back button disabled', async () => {
+    const backButton = app.locate('button', 'Go Back');
+    await expect(backButton).toBeDisabled();
+  });
+
   test('session queries are the default and ordered properly in history', async () => {
     await app.query('1');
     await app.query('2');