ref: Use diagnostics channel for claude agent sdk wrapper (#1678)

Moves the claude agent sdk wrapper over to use diagnostic channels.

Author: lforst

js/src/instrumentation/core/stream-patcher.ts

@@ -28,19 +28,19 @@ export interface StreamPatchOptions<TChunk = unknown, TFinal = unknown> {
    * Called for each chunk as it's yielded.
    * Optional - if not provided, chunks are just collected.
    */
-  onChunk?: (chunk: TChunk) => void;
+  onChunk?: (chunk: TChunk) => void | Promise<void>;
 
   /**
    * Called when the stream completes successfully.
    * Receives all collected chunks.
    */
-  onComplete: (chunks: TChunk[]) => TFinal | void;
+  onComplete: (chunks: TChunk[]) => TFinal | void | Promise<TFinal | void>;
 
   /**
    * Called if the stream errors.
    * If not provided, errors are re-thrown after collection stops.
    */
-  onError?: (error: Error, chunks: TChunk[]) => void;
+  onError?: (error: Error, chunks: TChunk[]) => void | Promise<void>;
 
   /**
    * Filter to decide whether to collect a chunk.
@@ -135,7 +135,7 @@ export function patchStreamIfNeeded<TChunk = unknown, TFinal = unknown>(
             if (!completed) {
               completed = true;
               try {
-                options.onComplete(chunks);
+                await options.onComplete(chunks);
               } catch (error) {
                 console.error("Error in stream onComplete handler:", error);
               }
@@ -155,7 +155,7 @@ export function patchStreamIfNeeded<TChunk = unknown, TFinal = unknown>(
               // Call onChunk handler if provided
               if (options.onChunk) {
                 try {
-                  options.onChunk(chunk);
+                  await options.onChunk(chunk);
                 } catch (error) {
                   console.error("Error in stream onChunk handler:", error);
                 }
@@ -170,7 +170,7 @@ export function patchStreamIfNeeded<TChunk = unknown, TFinal = unknown>(
             completed = true;
             if (options.onError) {
               try {
-                options.onError(
+                await options.onError(
                   error instanceof Error ? error : new Error(String(error)),
                   chunks,
                 );
@@ -191,7 +191,7 @@ export function patchStreamIfNeeded<TChunk = unknown, TFinal = unknown>(
             completed = true;
             // Stream was cancelled/returned early
             try {
-              options.onComplete(chunks);
+              await options.onComplete(chunks);
             } catch (error) {
               console.error("Error in stream onComplete handler:", error);
             }
@@ -213,7 +213,7 @@ export function patchStreamIfNeeded<TChunk = unknown, TFinal = unknown>(
                 : new Error(String(rawError));
             if (options.onError) {
               try {
-                options.onError(error, chunks);
+                await options.onError(error, chunks);
               } catch (handlerError) {
                 console.error("Error in stream onError handler:", handlerError);
               }

js/src/instrumentation/plugins/claude-agent-sdk-plugin.ts

@@ -834,15 +834,14 @@ export class ClaudeAgentSDKPlugin extends BasePlugin {
                   );
                 });
             },
-            onComplete: () => {
-              void state.processing
+            onComplete: () =>
+              state.processing
                 .then(() => finalizeQuerySpan(state))
                 .finally(() => {
                   spans.delete(event);
-                });
-            },
-            onError: (error: Error) => {
-              void state.processing
+                }),
+            onError: (error: Error) =>
+              state.processing
                 .then(() => {
                   state.span.log({
                     error: error.message,
@@ -851,8 +850,7 @@ export class ClaudeAgentSDKPlugin extends BasePlugin {
                 .then(() => finalizeQuerySpan(state))
                 .finally(() => {
                   spans.delete(event);
-                });
-            },
+                }),
           });
 
           return;