Skip to content

Commit 42cc74d

Browse files
committed
rm unnecessary warnings
1 parent 33874e1 commit 42cc74d

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

scripts/release/validate-publishable-packages.mjs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// @ts-check
12
import {
23
DOCS_HOMEPAGE,
34
GITHUB_REPO_URL,
@@ -8,7 +9,6 @@ import {
89
} from "./_shared.mjs";
910

1011
const errors = [];
11-
const warnings = [];
1212

1313
const workspaceDirs = new Set(listWorkspacePackageDirs());
1414
const approvedPublishableDirs = new Set(
@@ -56,24 +56,12 @@ if (errors.length > 0) {
5656
for (const error of errors) {
5757
console.error(`- ${error}`);
5858
}
59-
if (warnings.length > 0) {
60-
console.error("\nWarnings:");
61-
for (const warning of warnings) {
62-
console.error(`- ${warning}`);
63-
}
64-
}
6559
process.exit(1);
6660
}
6761

6862
console.log(
6963
`Validated ${PUBLISHABLE_PACKAGES.length} publishable packages and ${PRIVATE_WORKSPACE_PACKAGES.length} private workspace packages.`,
7064
);
71-
if (warnings.length > 0) {
72-
console.log("Warnings:");
73-
for (const warning of warnings) {
74-
console.log(`- ${warning}`);
75-
}
76-
}
7765

7866
function validatePublishablePackage(workspaceDir, manifest) {
7967
const approved = PUBLISHABLE_PACKAGES.find((pkg) => pkg.dir === workspaceDir);
@@ -117,7 +105,7 @@ function validatePublishablePackage(workspaceDir, manifest) {
117105
}
118106

119107
if (manifest.homepage !== DOCS_HOMEPAGE) {
120-
warnings.push(
108+
errors.push(
121109
`${workspaceDir} (${manifest.name}) homepage should be ${DOCS_HOMEPAGE}`,
122110
);
123111
}

0 commit comments

Comments
 (0)