In articles autocomplete, page until we get max results

We limit results rows to a page defined by max, but because of
the per article rights check, some could be missed and we might
return less than max. Keep going until we fill max or run out
of records.

Author: cbrandtbuffalo

share/html/Helpers/Autocomplete/Articles

@@ -89,13 +89,21 @@ $articles->Limit(
     SUBCLAUSE       => 'excludeautocomplete'
 ) if @not_in;
 
+my $count = $articles->CountAll;
 my @suggestions;
-while (my $a = $articles->Next) {
-    next if $right and not $a->CurrentUserHasRight($right);
-    my $value = $a->$return;
-    my $suggestion = { label => $a->Name, value => $value };
-    $m->callback( CallbackName => "ModifySuggestion", suggestion => $suggestion, article => $a );
-    push @suggestions, $suggestion;
+# RT::Articles->AddRecord filters by ShowArticle right, so some DB records
+# may be skipped. Keep paging until we collect max visible articles.
+OUTER: while (@suggestions < $max) {
+    while (my $a = $articles->Next) {
+        next if $right and not $a->CurrentUserHasRight($right);
+        my $value = $a->$return;
+        my $suggestion = { label => $a->Name, value => $value };
+        $m->callback( CallbackName => "ModifySuggestion", suggestion => $suggestion, article => $a );
+        push @suggestions, $suggestion;
+        last OUTER if @suggestions >= $max;
+    }
+    $articles->NextPage;
+    last if $articles->FirstRow >= $count;
 }
 return @suggestions if defined wantarray;
 </%INIT>