Merge pull request #45 from apiiro/barnon/fix-webhook-create-array-response

Fix WebhookClient.CreateAsync array response handling

Author: barnon-apiiro

src/GitLabApiClient/GitLabApiClient.csproj

@@ -4,7 +4,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <LangVersion>10</LangVersion>
     <PackageId>Apiiro.GitLabApiClient</PackageId>
-    <Version>0.1.44</Version>
+    <Version>0.1.45</Version>
     <Authors>Apiiro</Authors>
     <Company>Apiiro</Company>
     <PackageDescription>GitLabApiClient</PackageDescription>

src/GitLabApiClient/WebhookClient.cs

@@ -1,10 +1,13 @@
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
 using GitLabApiClient.Internal.Http;
 using GitLabApiClient.Internal.Paths;
 using GitLabApiClient.Models.Projects.Responses;
 using GitLabApiClient.Models.Webhooks.Requests;
 using GitLabApiClient.Models.Webhooks.Responses;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 
 namespace GitLabApiClient
 {
@@ -37,13 +40,23 @@ public async Task<IList<Webhook>> GetAsync(ProjectId projectId)
         }
 
         /// <summary>
-        /// Create new webhook
+        /// Create new webhook.
+        /// Some GitLab versions return a JSON array from POST /projects/:id/hooks
+        /// instead of a single object. We deserialize as JToken to handle both formats.
         /// </summary>
         /// <param name="projectId">The ID, path or <see cref="Project"/> of the project.</param>
         /// <param name="request">Create hook request.</param>
         /// <returns>newly created hook</returns>
-        public async Task<Webhook> CreateAsync(ProjectId projectId, CreateWebhookRequest request) =>
-            await _httpFacade.Post<Webhook>($"projects/{projectId}/hooks", request);
+        public async Task<Webhook> CreateAsync(ProjectId projectId, CreateWebhookRequest request)
+        {
+            var token = await _httpFacade.Post<JToken>($"projects/{projectId}/hooks", request);
+            return token switch
+            {
+                JArray array => array.FirstOrDefault()?.ToObject<Webhook>(),
+                JObject obj => obj.ToObject<Webhook>(),
+                _ => null
+            };
+        }
 
         /// <summary>
         /// Delete a webhook