Skip to content

Commit 1d84302

Browse files
committed
Fix Dubbo 3.3 support: replace dubbo-dependencies-zookeeper with direct deps
dubbo-dependencies-zookeeper was removed in Dubbo 3.3. Replace with: - dubbo-registry-zookeeper (exists in all 3.x versions) - curator-x-discovery (overridable via run.sh property for 3.3+) - zookeeper 3.5.9 (for embedded ZK server compatibility) Locally verified: 3.0.4, 3.1.11, 3.2.19, 3.3.4 all passed.
1 parent ce1fe02 commit 1d84302

4 files changed

Lines changed: 16 additions & 5 deletions

File tree

CHANGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Release Notes.
1818
* Extend Spring Kafka plugin to support Spring Kafka 2.4 -> 2.9 and 3.0 -> 3.3.
1919
* Enhance test/plugin/run.sh to support extra Maven properties per version in support-version.list (format: version,key=value).
2020
* Extend OkHttp plugin to support OkHttp 4.10 -> 4.12.
21-
* Extend Dubbo 3.x plugin to support Dubbo 3.1 -> 3.2.
21+
* Extend Dubbo 3.x plugin to support Dubbo 3.1 -> 3.3. Replace dubbo-dependencies-zookeeper (removed in 3.3) with direct dependencies in test scenario.
2222

2323
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/249?closed=1)
2424

docs/en/setup/service-agent/java-agent/Supported-list.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ metrics based on the tracing data.
6060
* RPC Frameworks
6161
* [Dubbo](https://github.com/alibaba/dubbo) 2.5.4 -> 2.6.0
6262
* [Dubbox](https://github.com/dangdangdotcom/dubbox) 2.8.4
63-
* [Apache Dubbo](https://github.com/apache/dubbo) 2.7.x -> 3.2.x
63+
* [Apache Dubbo](https://github.com/apache/dubbo) 2.7.x -> 3.3.x
6464
* [Motan](https://github.com/weibocom/motan) 0.2.x -> 1.1.0
6565
* [gRPC](https://github.com/grpc/grpc-java) 1.x
6666
* [Apache ServiceComb Java Chassis](https://github.com/apache/servicecomb-java-chassis) 1.x, 2.x

test/plugin/scenarios/dubbo-3.x-scenario/pom.xml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333

3434
<test.framework>dubbo</test.framework>
3535
<test.framework.version>3.0.0</test.framework.version>
36+
<curator.version>5.1.0</curator.version>
37+
<zookeeper.version>3.5.9</zookeeper.version>
3638
</properties>
3739

3840
<name>skywalking-dubbo-3.x-scenario</name>
@@ -63,9 +65,18 @@
6365
</dependency>
6466
<dependency>
6567
<groupId>org.apache.dubbo</groupId>
66-
<artifactId>dubbo-dependencies-zookeeper</artifactId>
68+
<artifactId>dubbo-registry-zookeeper</artifactId>
6769
<version>${test.framework.version}</version>
68-
<type>pom</type>
70+
</dependency>
71+
<dependency>
72+
<groupId>org.apache.curator</groupId>
73+
<artifactId>curator-x-discovery</artifactId>
74+
<version>${curator.version}</version>
75+
</dependency>
76+
<dependency>
77+
<groupId>org.apache.zookeeper</groupId>
78+
<artifactId>zookeeper</artifactId>
79+
<version>${zookeeper.version}</version>
6980
</dependency>
7081
</dependencies>
7182

test/plugin/scenarios/dubbo-3.x-scenario/support-version.list

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# dubbo-dependencies-zookeeper module not published for 3.3+, needs pom change
1817
3.0.4
1918
3.1.11
2019
3.2.19
20+
3.3.4,curator.version=5.7.1

0 commit comments

Comments
 (0)