Skip to content

Commit fb81652

Browse files
julienledemclaude
andcommitted
Skip ALP in encoding equivalence test
ALP encoding is not yet part of the parquet-format Thrift specification, so it cannot be converted to org.apache.parquet.format.Encoding. Skip it in the testEnumEquivalence test and add a clear error message in the converter for when ALP conversion is attempted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent dfdd809 commit fb81652

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -748,6 +748,11 @@ public org.apache.parquet.column.Encoding getEncoding(Encoding encoding) {
748748
}
749749

750750
public Encoding getEncoding(org.apache.parquet.column.Encoding encoding) {
751+
// ALP encoding is not yet part of the parquet-format specification
752+
if (encoding == org.apache.parquet.column.Encoding.ALP) {
753+
throw new IllegalArgumentException(
754+
"ALP encoding is not yet supported in the parquet-format specification");
755+
}
751756
return Encoding.valueOf(encoding.name());
752757
}
753758

parquet-hadoop/src/test/java/org/apache/parquet/format/converter/TestParquetMetadataConverter.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,10 @@ public void testLogicalToConvertedTypeConversion() {
471471
public void testEnumEquivalence() {
472472
ParquetMetadataConverter parquetMetadataConverter = new ParquetMetadataConverter();
473473
for (org.apache.parquet.column.Encoding encoding : org.apache.parquet.column.Encoding.values()) {
474+
// Skip ALP encoding as it's not yet in the parquet-format specification
475+
if (encoding == org.apache.parquet.column.Encoding.ALP) {
476+
continue;
477+
}
474478
assertEquals(
475479
encoding, parquetMetadataConverter.getEncoding(parquetMetadataConverter.getEncoding(encoding)));
476480
}

0 commit comments

Comments
 (0)