CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it

Author: nvazquez

engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java

@@ -150,4 +150,9 @@ public interface VMInstanceDao extends GenericDao<VMInstanceVO, Long>, StateDao<
     VMInstanceVO findVMByHostNameInZone(String hostName, long zoneId);
 
     boolean isPowerStateUpToDate(long instanceId);
+
+    /**
+     * List running VMs which host and lastHost id are the same
+     */
+    List<VMInstanceVO> listRunningVmsByHostAndLastHostSameId(long hostId);
 }

engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java

@@ -304,6 +304,15 @@ public List<VMInstanceVO> listByHostId(long hostid) {
         return listBy(sc);
     }
 
+    @Override
+    public List<VMInstanceVO> listRunningVmsByHostAndLastHostSameId(long hostId) {
+        SearchCriteria<VMInstanceVO> sc = AllFieldsSearch.create();
+        sc.setParameters("host", hostId);
+        sc.setParameters("lastHost", hostId);
+        sc.setParameters("state", State.Running);
+        return listBy(sc);
+    }
+
     @Override
     public List<VMInstanceVO> listByZoneId(long zoneId) {
         SearchCriteria<VMInstanceVO> sc = AllFieldsSearch.create();

server/src/com/cloud/resource/ResourceManagerImpl.java

@@ -1296,7 +1296,8 @@ public boolean checkAndMaintain(final long hostId) {
             if (host.getType() != Host.Type.Storage) {
                 final List<VMInstanceVO> vos = _vmDao.listByHostId(hostId);
                 final List<VMInstanceVO> vosMigrating = _vmDao.listVmsMigratingFromHost(hostId);
-                if (vos.isEmpty() && vosMigrating.isEmpty()) {
+                final List<VMInstanceVO> failedMigratedVms = _vmDao.listRunningVmsByHostAndLastHostSameId(hostId);
+                if (vos.isEmpty() && vosMigrating.isEmpty() && failedMigratedVms.isEmpty()) {
                     resourceStateTransitTo(host, ResourceState.Event.InternalEnterMaintenance, _nodeId);
                     hostInMaintenance = true;
                     ActionEventUtils.onCompletedActionEvent(CallContext.current().getCallingUserId(), CallContext.current().getCallingAccountId(), EventVO.LEVEL_INFO, EventTypes.EVENT_MAINTENANCE_PREPARE, "completed maintenance for host " + hostId, 0);