Skip to content

Commit 0c943ab

Browse files
authored
CertUtils: export private key to pem format correctly (#2875)
This makes openssl rsa -in <file> -check pass, due to "RSA" string the validate of private key (pem file) by openssl fails. Also removes a commented import. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
1 parent 8c0b9d6 commit 0c943ab

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

  • utils/src/main/java/org/apache/cloudstack/utils/security

utils/src/main/java/org/apache/cloudstack/utils/security/CertUtils.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@
7575

7676
import com.google.common.base.Strings;
7777

78-
//import org.bouncycastle.x509.extension.SubjectKeyIdentifierStructure;
79-
8078
public class CertUtils {
8179

8280
private static final Logger LOG = Logger.getLogger(CertUtils.class);
@@ -132,7 +130,7 @@ public static PrivateKey pemToPrivateKey(final String pem) throws InvalidKeySpec
132130
}
133131

134132
public static String privateKeyToPem(final PrivateKey key) throws IOException {
135-
final PemObject pemObject = new PemObject("RSA PRIVATE KEY", key.getEncoded());
133+
final PemObject pemObject = new PemObject("PRIVATE KEY", key.getEncoded());
136134
final StringWriter sw = new StringWriter();
137135
try (final PemWriter pw = new PemWriter(sw)) {
138136
pw.writeObject(pemObject);

0 commit comments

Comments
 (0)