Skip to content

Commit a375d6c

Browse files
authored
FileBasedSinkTest failure (#38284)
1 parent 7597370 commit a375d6c

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

  • sdks/java/core/src/main/java/org/apache/beam/sdk/metrics

sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Lineage.java

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.apache.beam.sdk.lineage.LineageOptions;
3131
import org.apache.beam.sdk.metrics.Metrics.MetricsFlag;
3232
import org.apache.beam.sdk.options.PipelineOptions;
33+
import org.apache.beam.sdk.options.PipelineOptionsFactory;
3334
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.annotations.VisibleForTesting;
3435
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Splitter;
3536
import org.checkerframework.checker.nullness.qual.Nullable;
@@ -122,16 +123,24 @@ private static Lineage createLineage(PipelineOptions options, LineageDirection d
122123

123124
/** {@link Lineage} representing sources and optionally side inputs. */
124125
public static Lineage getSources() {
125-
return checkNotNull(
126-
sources,
127-
"Lineage not initialized. FileSystems.setDefaultPipelineOptions must be called first.");
126+
Lineage localSources = sources;
127+
if (localSources == null) {
128+
return createDefaultLineage(LineageDirection.SOURCE);
129+
}
130+
return localSources;
128131
}
129132

130133
/** {@link Lineage} representing sinks. */
131134
public static Lineage getSinks() {
132-
return checkNotNull(
133-
sinks,
134-
"Lineage not initialized. FileSystems.setDefaultPipelineOptions must be called first.");
135+
Lineage localSinks = sinks;
136+
if (localSinks == null) {
137+
return createDefaultLineage(LineageDirection.SINK);
138+
}
139+
return localSinks;
140+
}
141+
142+
private static Lineage createDefaultLineage(LineageDirection direction) {
143+
return createLineage(PipelineOptionsFactory.create(), direction);
135144
}
136145

137146
@VisibleForTesting

0 commit comments

Comments
 (0)