Skip to content

Commit f386fdb

Browse files
committed
Enable USB PHYs a bit earlier and re-enable OhciDxe
There's no clear dependency set here. It may be better to register a protocol for this instead.
1 parent 8249a40 commit f386fdb

7 files changed

Lines changed: 16 additions & 11 deletions

File tree

edk2-platforms/Platform/OrangePi/OrangePi5/Drivers/RK3588Dxe_opi5/RK3588Dxe.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,12 @@ RK3588InitPeripherals (
498498

499499
// GmacIomuxInit();
500500

501+
/* Enable USB PHYs */
502+
Usb2PhyResume ();
503+
UsbDpPhyEnable ();
504+
505+
UsbPortPowerEnable ();
506+
501507
return EFI_SUCCESS;
502508
}
503509

edk2-platforms/Platform/OrangePi/OrangePi5/OrangePi5.dsc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@
453453
#
454454
# USB Ohci Controller
455455
#
456-
#Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
456+
Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
457457

458458
#
459459
# USB Ehci Controller

edk2-platforms/Platform/OrangePi/OrangePi5/OrangePi5.fdf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ READ_LOCK_STATUS = TRUE
185185
#
186186
# USB Ohci Controller
187187
#
188-
#INF Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
188+
INF Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
189189

190190
#
191191
# USB Dwc3 Controller

edk2-platforms/Platform/Radxa/ROCK5B/Drivers/RK3588Dxe_rock5b/RK3588Dxe.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,12 @@ RK3588InitPeripherals (
486486

487487
ComboPhyInit();
488488

489+
/* Enable USB PHYs */
490+
Usb2PhyResume ();
491+
UsbDpPhyEnable ();
492+
493+
UsbPortPowerEnable ();
494+
489495
return EFI_SUCCESS;
490496
}
491497

edk2-platforms/Platform/Radxa/ROCK5B/ROCK5B.dsc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@
453453
#
454454
# USB Ohci Controller
455455
#
456-
#Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
456+
Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
457457

458458
#
459459
# USB Ehci Controller

edk2-platforms/Platform/Radxa/ROCK5B/ROCK5B.fdf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ READ_LOCK_STATUS = TRUE
185185
#
186186
# USB Ohci Controller
187187
#
188-
#INF Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
188+
INF Silicon/Rockchip/Drivers/OhciDxe/OhciDxe.inf
189189

190190
#
191191
# USB Dwc3 Controller

edk2-platforms/Silicon/Rockchip/Drivers/UsbHcdInitDxe/UsbHcd.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -258,13 +258,6 @@ UsbEndOfDxeCallback (
258258

259259
NumUsb2Controller = PcdGet32 (PcdNumEhciController);
260260

261-
/* Enable USB PHYs */
262-
Usb2PhyResume();
263-
264-
UsbDpPhyEnable();
265-
266-
UsbPortPowerEnable ();
267-
268261
/* Register USB3 controllers */
269262
for (Index = 0; Index < XhciControllerAddrArraySize; Index += sizeof(UINT32)) {
270263
XhciControllerAddr = XhciControllerAddrArrayPtr[Index] |

0 commit comments

Comments
 (0)