feat: logging to file must be excplicitly activated #205

Author: rwxd

README.md

@@ -326,6 +326,7 @@ index_html: |
 ```bash
 LOG_LEVEL=DEBUG       # Optional: DEBUG, INFO, WARNING, ERROR (default: DEBUG)
 LOG_FORMAT=json       # Optional: "text" (default) or "json" for structured logging
+LOG_FILE=/var/log/app.log  # Optional: Enable file logging to specified path (default: disabled, logs to stderr only)
 LISTEN_HOST=0.0.0.0   # Optional: Host to bind to (default: *)
 LISTEN_PORT=8000      # Optional: Port to listen on (default: 8000)
 ```

powerdns_api_proxy/logging.py

@@ -96,14 +96,16 @@ def audit(
 default_stream_handler.setLevel(LOG_LEVEL)
 default_stream_handler.setFormatter(default_formatter)
 
-file_handler = logging.handlers.RotatingFileHandler(
-    filename="log", maxBytes=1000**2 * 100, backupCount=5
-)
-file_handler.setLevel("DEBUG")
-file_handler.setFormatter(default_formatter)
-
 logger: AuditLogger = logging.getLogger("powerdns_api_proxy")  # type: ignore
 logger.addHandler(default_stream_handler)
-logger.addHandler(file_handler)
+
+LOG_FILE = getenv("LOG_FILE")
+if LOG_FILE:
+    file_handler = logging.handlers.RotatingFileHandler(
+        filename=LOG_FILE, maxBytes=1000**2 * 100, backupCount=5
+    )
+    file_handler.setLevel("DEBUG")
+    file_handler.setFormatter(default_formatter)
+    logger.addHandler(file_handler)
 
 logger.setLevel("DEBUG")