Skip to content

Commit 515ab50

Browse files
authored
fewer shell warnings (#234)
Given the very explicit command line flags we can avoid printing the non-standard params when running in the shell. - Only console.warn non-default params in the browser - Only console.warn disabled resource prefetching in the browser
1 parent f88580e commit 515ab50

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

JetStreamDriver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const measureTotalTimeAsSubtest = false; // Once we move to preloading all resou
3030
const defaultIterationCount = 120;
3131
const defaultWorstCaseCount = 4;
3232

33-
if (!JetStreamParams.prefetchResources)
33+
if (!JetStreamParams.prefetchResources && isInBrowser)
3434
console.warn("Disabling resource prefetching! All compressed files must have been decompressed using `npm run decompress`");
3535

3636
if (!isInBrowser && JetStreamParams.prefetchResources) {

cli.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,6 @@ load("./utils/params.js");
124124

125125

126126
async function runJetStream() {
127-
if (!JetStreamParams.isDefault) {
128-
const paramsDiff = JetStreamParams.nonDefaultParams;
129-
console.warn(`Using non standard params: ${JSON.stringify(paramsDiff, null, 2)}`)
130-
}
131127
try {
132128
await JetStream.initialize();
133129
await JetStream.start();

index.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@
7373
function showNonDefaultParams() {
7474
document.body.classList.add("nonDefaultParams");
7575
const body = document.querySelector("#non-standard-params-table tbody");
76-
for (const [key, value] of Object.entries(JetStreamParams.nonDefaultParams)) {
76+
const nonDefaultParams = JetStreamParams.nonDefaultParams;
77+
console.warn(`Using non standard params: ${JSON.stringify(nonDefaultParams, null, 2)}`)
78+
for (const [key, value] of Object.entries(nonDefaultParams)) {
7779
const defaultValue = DefaultJetStreamParams[key]
7880
const row = body.insertRow();
7981
row.insertCell().textContent = key;

0 commit comments

Comments
 (0)