Skip to content

Commit b566182

Browse files
author
Idan Harel
committed
Fixed an error, upgraded to 1.0.7
1 parent c969455 commit b566182

7 files changed

Lines changed: 11 additions & 27 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This library is released on [maven central](http://central.maven.org/maven2/com/
1616
### Gradle
1717

1818
```
19-
compile group: 'com.viber', name: 'viber-bot', version: '1.0.6'
19+
compile group: 'com.viber', name: 'viber-bot', version: '1.0.7'
2020
```
2121

2222
### Maven
@@ -25,7 +25,7 @@ compile group: 'com.viber', name: 'viber-bot', version: '1.0.6'
2525
<dependency>
2626
<groupId>com.viber</groupId>
2727
<artifactId>viber-bot</artifactId>
28-
<version>1.0.6</version>
28+
<version>1.0.7</version>
2929
</dependency>
3030
```
3131

nano-httpd-sample/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ repositories {
1010
}
1111

1212
dependencies {
13-
compile group: 'com.viber', name: 'viber-bot', version: '1.0.6'
13+
compile group: 'com.viber', name: 'viber-bot', version: '1.0.7'
1414
compile group: 'org.nanohttpd', name: 'nanohttpd', version: '2.3.1'
1515
compile group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.21'
1616
}

spring-boot-sample/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ repositories {
1010
}
1111

1212
dependencies {
13-
compile group: 'com.viber', name: 'viber-bot', version: '1.0.6'
13+
compile group: 'com.viber', name: 'viber-bot', version: '1.0.7'
1414
compile group: 'org.springframework.boot', name: 'spring-boot-starter-web', version: '1.4.2.RELEASE'
1515
compile group: 'javax.inject', name: 'javax.inject', version: '1'
1616
}

src/main/java/com/viber/bot/api/ViberClient.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class ViberClient {
3333
static final String VIBER_AUTH_TOKEN_HEADER = "X-Viber-Auth-Token";
3434
static final String USER_AGENT_HEADER_FIELD = "User-Agent";
3535
static final String USER_AGENT_HEADER_VALUE = "ViberBot-Java/";
36+
static final String VIBER_LIBRARY_VERSION = "1.0.7";
3637

3738
private static final String STATUS = "status";
3839
private static final int MAX_GET_ONLINE_IDS = 100;
@@ -51,7 +52,7 @@ class ViberClient {
5152
ViberClient(final @Nonnull String apiUrl, final @Nonnull String authToken) {
5253
this.apiUrl = checkNotEmpty(apiUrl);
5354
this.authToken = checkNotEmpty(authToken);
54-
this.userAgent = String.format("%s%s", USER_AGENT_HEADER_VALUE, fetchUserAgentVersion());
55+
this.userAgent = String.format("%s%s", USER_AGENT_HEADER_VALUE, VIBER_LIBRARY_VERSION);
5556
}
5657

5758
ListenableFuture<ApiResponse> setWebhook(final @Nullable String url, final @Nonnull Collection<Event> events) {
@@ -84,18 +85,6 @@ ListenableFuture<ApiResponse> getOnlineStatus(final @Nonnull Collection<String>
8485
}});
8586
}
8687

87-
@VisibleForTesting
88-
String fetchUserAgentVersion() {
89-
Properties properties = new Properties();
90-
try {
91-
properties.load(getClass().getClassLoader().getResourceAsStream("./version.properties"));
92-
return properties.getProperty("version");
93-
} catch (Exception e) {
94-
logger.error("Could not fetch user agent", e);
95-
return "unknown";
96-
}
97-
}
98-
9988
@VisibleForTesting
10089
Request createRequest(@Nonnull Endpoint endpoint, RequestBody body) {
10190
return new Request.Builder()

src/main/java/com/viber/bot/message/MessageKeyboard.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
public class MessageKeyboard extends ForwardingMap<String, Object> {
2525
private final Map<String, Object> map;
2626

27-
MessageKeyboard(final @Nullable Map<String, Object> delegate) {
27+
public MessageKeyboard(final @Nullable Map<String, Object> delegate) {
2828
this.map = Collections.unmodifiableMap(MoreObjects.firstNonNull(delegate, Collections.emptyMap()));
2929
}
3030

31-
MessageKeyboard() {
31+
public MessageKeyboard() {
3232
this(null);
3333
}
3434

src/main/java/com/viber/bot/message/TrackingData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
public class TrackingData extends ForwardingMap<String, Object> {
2525
private final Map<String, Object> map;
2626

27-
TrackingData(final @Nullable Map<String, Object> delegate) {
27+
public TrackingData(final @Nullable Map<String, Object> delegate) {
2828
this.map = Collections.unmodifiableMap(MoreObjects.firstNonNull(delegate, Collections.emptyMap()));
2929
}
3030

31-
TrackingData() {
31+
public TrackingData() {
3232
this(null);
3333
}
3434

src/test/java/com/viber/bot/api/ViberClientTest.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ public class ViberClientTest {
1212
private static final ViberClient client = new ViberClient("http://url.com", "TOKEN");
1313
private static final RequestBody EMPTY_REQUEST_BODY = RequestBody.create(MediaType.parse("application/json; charset=utf-8"), "");
1414

15-
@Test
16-
public void testFetchUserAgentSanity() {
17-
assertThat(client.fetchUserAgentVersion()).isNotEmpty();
18-
}
19-
2015
@Test
2116
public void testCreateRequestAuthTokenExistsSanity() {
2217
Request request = client.createRequest(ViberClient.Endpoint.SEND_MESSAGE, EMPTY_REQUEST_BODY);
@@ -29,6 +24,6 @@ public void testCreateRequestUserAgentExistsSanity() {
2924
Request request = client.createRequest(ViberClient.Endpoint.SEND_MESSAGE, EMPTY_REQUEST_BODY);
3025
assertThat(request.headers().get(ViberClient.USER_AGENT_HEADER_FIELD)).isNotEmpty();
3126
assertThat(request.headers().get(ViberClient.USER_AGENT_HEADER_FIELD))
32-
.isEqualTo(String.format("%s%s", ViberClient.USER_AGENT_HEADER_VALUE, client.fetchUserAgentVersion()));
27+
.isEqualTo(String.format("%s%s", ViberClient.USER_AGENT_HEADER_VALUE, ViberClient.VIBER_LIBRARY_VERSION));
3328
}
3429
}

0 commit comments

Comments
 (0)