Skip to content

Commit b9113d3

Browse files
committed
Fixed missing generated seed input to pre_config hook.
1 parent 9498a91 commit b9113d3

4 files changed

Lines changed: 16 additions & 1 deletion

File tree

docs/news.d/1178.bug.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed missing generated seed input to pre_config hook.

tests/acceptance/artificial/vhdl/run.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ def pre_config(seed):
174174
print(f"pre_config seed: {seed}")
175175
if not expected_seed:
176176
assert seed != "0123456789abcdef"
177+
assert seed is not None
177178
else:
178179
assert seed == expected_seed
179180

@@ -190,6 +191,8 @@ def pre_config(seed):
190191
tb.test("test_2").set_generic("expected_seed", "9a292b3679afd081")
191192
tb.test("test_1").set_pre_config(make_pre_config("7ac31eb89c4059f9"))
192193
tb.test("test_2").set_pre_config(make_pre_config("8b1cd665d806e572"))
194+
elif args.seed is None:
195+
tb.set_pre_config(make_pre_config())
193196

194197

195198
def configure_tb_vunit_pkg(vu):

tests/acceptance/test_artificial.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,16 @@ def test_repeated_seed(self):
107107
],
108108
)
109109

110+
def test_generated_seed(self):
111+
self.check(self.artificial_run_vhdl, args=["lib.tb_seed*"])
112+
check_report(
113+
self.report_file,
114+
[
115+
("passed", "lib.tb_seed.test_1"),
116+
("passed", "lib.tb_seed.test_2"),
117+
],
118+
)
119+
110120
def test_not_executing_package_init_on_package_addition(self):
111121
self.check(self.artificial_run_vhdl, args=["lib.tb_vunit_pkg.all"])
112122
check_report(

vunit/test/suites.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ def run(self, output_path, read_output):
211211
for name in self._test_cases:
212212
results[name] = FAILED
213213

214-
if not self._config.call_pre_config(output_path, self._simulator_if.output_path, self._seed):
214+
seed = self.get_seed()
215+
if not self._config.call_pre_config(output_path, self._simulator_if.output_path, seed):
215216
return results
216217

217218
# Ensure result file exists

0 commit comments

Comments
 (0)