Skip to content

Commit b58fbb1

Browse files
committed
Removing duplicate functionality.
1 parent b15dec2 commit b58fbb1

2 files changed

Lines changed: 9 additions & 27 deletions

File tree

vunit/test/common.py

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,38 +10,20 @@
1010

1111

1212
from xml.etree import ElementTree
13-
from vunit.modelsim_interface import ModelSimInterface
14-
from os import environ
15-
16-
SIMULATORS = [ModelSimInterface]
17-
18-
19-
def _get_simulator_to_use():
20-
"""
21-
Return the class of the simulator to use
22-
"""
23-
key = "VUNIT_SIMULATOR"
24-
if key in environ:
25-
for sim in SIMULATORS:
26-
if sim.name == environ[key]:
27-
return sim
28-
else:
29-
return SIMULATORS[0]
30-
assert False
13+
from vunit import VUnit
3114

3215

3316
def has_simulator():
34-
return _get_simulator_to_use().is_available()
17+
return VUnit.select_simulator().is_available()
3518

3619

3720
def simulator_is(*names):
3821
"""
3922
Check that current simulator is any of names
4023
"""
41-
simulator_names = [sim.name for sim in SIMULATORS]
4224
for name in names:
43-
assert name in simulator_names
44-
return _get_simulator_to_use().name in names
25+
assert name in VUnit.available_simulators()
26+
return VUnit.select_simulator().name in names
4527

4628

4729
def check_report(report_file, tests):

vunit/ui.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_filter(name):
7878
gui_mode=args.gui,
7979
compile_builtins=compile_builtins,
8080
persistent_sim=os.environ.get("VUNIT_PERSISTENT_SIM", "True") == "True",
81-
simulator_class=cls._select_simulator())
81+
simulator_class=cls.select_simulator())
8282

8383
@classmethod
8484
def _create_argument_parser(cls):
@@ -141,7 +141,7 @@ def _create_argument_parser(cls):
141141
return parser
142142

143143
@staticmethod
144-
def _available_simulators():
144+
def available_simulators():
145145
"""
146146
Return a list of available simulators
147147
"""
@@ -154,12 +154,12 @@ def _available_simulators():
154154
return sims
155155

156156
@classmethod
157-
def _select_simulator(cls):
157+
def select_simulator(cls):
158158
"""
159159
Select simulator class, either from VUNIT_SIMULATOR environment variable
160160
or the first available
161161
"""
162-
simulators = cls._available_simulators()
162+
simulators = cls.available_simulators()
163163
environ_name = "VUNIT_SIMULATOR"
164164

165165
if environ_name in os.environ:
@@ -221,7 +221,7 @@ def __init__(self, # pylint: disable=too-many-locals, too-many-arguments
221221
if simulator_class is not None:
222222
self._simulator_class = simulator_class
223223
else:
224-
self._simulator_class = self._available_simulators().values()[0]
224+
self._simulator_class = self.available_simulators().values()[0]
225225

226226
self._sim_specific_path = join(self._output_path, self._simulator_class.name)
227227
self._create_output_path(clean)

0 commit comments

Comments
 (0)