Skip to content

Commit fe2ccfa

Browse files
authored
Merge pull request #46 from SorsOps/main
Prevent duplicate labels
2 parents dd63933 + f2bdc93 commit fe2ccfa

7 files changed

Lines changed: 20 additions & 19 deletions

File tree

charts/tooljet/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ Common labels
3535
*/}}
3636
{{- define "tooljet.labels" -}}
3737
helm.sh/chart: {{ include "tooljet.chart" . }}
38-
{{ include "tooljet.selectorLabels" . }}
3938
{{- if .Chart.AppVersion }}
4039
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
4140
{{- end }}
4241
app.kubernetes.io/managed-by: {{ .Release.Service }}
4342
{{- end }}
4443

44+
4545
{{/*
4646
Selector labels
4747
*/}}

charts/tooljet/templates/deployment-pgrst.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,22 @@ metadata:
44
name: {{ include "tooljet.fullname" . }}-postgrest
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7-
app.kubernetes.io/component: tooljet-postgrest
8-
app.kubernetes.io/instance: tooljet-postgrest
9-
app.kubernetes.io/name: tooljet-postgrest
7+
app.kubernetes.io/component: {{ .Release.Name }}-postgrest
8+
app.kubernetes.io/instance: {{ .Release.Name }}-postgrest
9+
app.kubernetes.io/name: {{ .Release.Name }}-postgrest
1010
spec:
1111
replicas: {{ .Values.postgrest.replicaCount | default 1 }}
1212
selector:
1313
matchLabels:
14-
{{- include "tooljet.selectorLabels" . | nindent 6 }}
15-
app.kubernetes.io/component: tooljet-postgrest
16-
app.kubernetes.io/instance: tooljet-postgrest
17-
app.kubernetes.io/name: tooljet-postgrest
14+
app.kubernetes.io/component: {{ .Release.Name }}-postgrest
15+
app.kubernetes.io/instance: {{ .Release.Name }}-postgrest
16+
app.kubernetes.io/name: {{ .Release.Name }}-postgrest
1817
template:
1918
metadata:
2019
labels:
21-
{{- include "tooljet.selectorLabels" . | nindent 8 }}
22-
app.kubernetes.io/component: tooljet-postgrest
23-
app.kubernetes.io/instance: tooljet-postgrest
24-
app.kubernetes.io/name: tooljet-postgrest
20+
app.kubernetes.io/component: {{ .Release.Name }}-postgrest
21+
app.kubernetes.io/instance: {{ .Release.Name }}-postgrest
22+
app.kubernetes.io/name: {{ .Release.Name }}-postgrest
2523
spec:
2624
containers:
2725
- name: postgrest

charts/tooljet/templates/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ metadata:
44
name: {{ include "tooljet.fullname" . }}
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7+
{{- include "tooljet.selectorLabels" . | nindent 4 }}
78
spec:
89
{{- if not .Values.autoscaling.enabled }}
910
replicas: {{ .Values.apps.tooljet.replicaCount }}

charts/tooljet/templates/ingress.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ metadata:
44
name: {{ include "tooljet.fullname" . }}
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7+
{{- include "tooljet.selectorLabels" . | nindent 4 }}
78
{{- with .Values.ingress.annotations }}
89
annotations:
910
{{- toYaml . | nindent 4 }}

charts/tooljet/templates/secret.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ metadata:
44
name: {{ .Values.apps.tooljet.secret.name }}
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7+
{{- include "tooljet.selectorLabels" . | nindent 4 }}
78
type: Opaque
89
data:
910
{{- if not .Values.external_postgresql.enabled }}

charts/tooljet/templates/service-pgrst.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@ metadata:
44
name: {{ include "tooljet.fullname" . }}-postgrest
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7-
app.kubernetes.io/component: tooljet-postgrest
8-
app.kubernetes.io/instance: tooljet-postgrest
9-
app.kubernetes.io/name: tooljet-postgrest
7+
app.kubernetes.io/component: {{ .Release.Name }}-postgrest
8+
app.kubernetes.io/instance: {{ .Release.Name }}-postgrest
9+
app.kubernetes.io/name: {{ .Release.Name }}-postgrest
1010
spec:
1111
selector:
12-
{{- include "tooljet.selectorLabels" . | nindent 4 }}
13-
app.kubernetes.io/component: tooljet-postgrest
14-
app.kubernetes.io/instance: tooljet-postgrest
15-
app.kubernetes.io/name: tooljet-postgrest
12+
app.kubernetes.io/component: {{ .Release.Name }}-postgrest
13+
app.kubernetes.io/instance: {{ .Release.Name }}-postgrest
14+
app.kubernetes.io/name: {{ .Release.Name }}-postgrest
1615
type: {{ .Values.postgrest.service.type }}
1716
ports:
1817
- name: http

charts/tooljet/templates/service.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ metadata:
44
name: {{ include "tooljet.fullname" . }}
55
labels:
66
{{- include "tooljet.labels" . | nindent 4 }}
7+
{{- include "tooljet.selectorLabels" . | nindent 4 }}
78
spec:
89
type: {{ .Values.apps.tooljet.service.type }}
910
ports:

0 commit comments

Comments
 (0)