Added some doc and abstracted more methods

Author: litetex

app/src/main/java/org/schabi/newpipe/player/helper/PlaybackParameterDialog.java

@@ -172,7 +172,7 @@ public Dialog onCreateDialog(@Nullable final Bundle savedInstanceState) {
     }
 
     /*//////////////////////////////////////////////////////////////////////////
-    // Control Views
+    // UI Initialization and Control
     //////////////////////////////////////////////////////////////////////////*/
 
     private void initUI() {
@@ -265,8 +265,7 @@ private void initUI() {
                 isChecked -> {
                     if (!isChecked) {
                         // when unchecked, slide back to the minimum of current tempo or pitch
-                        setSliders(Math.min(pitchPercent, tempo));
-                        updateCallback();
+                        ensureHookIsValidAndUpdateCallBack();
                     }
                 });
 
@@ -277,6 +276,8 @@ private void initUI() {
         });
     }
 
+    // -- General formatting --
+
     private void setText(
             final TextView textView,
             final DoubleFunction<String> formatter,
@@ -285,6 +286,8 @@ private void setText(
         Objects.requireNonNull(textView).setText(formatter.apply(value));
     }
 
+    // -- Steps --
+
     private void registerOnStepClickListener(
             final TextView stepTextView,
             final DoubleSupplier currentValueSupplier,
@@ -310,6 +313,8 @@ private void registerOnSemitoneStepClickListener(
         });
     }
 
+    // -- Pitch --
+
     private void setupPitchControlModeTextView(
             final boolean semitones,
             final TextView textView
@@ -367,6 +372,9 @@ private void changePitchControlMode(final boolean semitones) {
                 this.onPitchPercentSliderUpdated(newPitchPercent);
                 updateCallback();
             }
+        } else if (!binding.unhookCheckbox.isChecked()) {
+            // When changing to percent it's possible that tempo is != pitch
+            ensureHookIsValidAndUpdateCallBack();
         }
     }
 
@@ -377,6 +385,8 @@ private boolean isCurrentPitchControlModeSemitone() {
                         PITCH_CTRL_MODE_PERCENT);
     }
 
+    // -- Steps (Set) --
+
     private void setupStepTextView(
             final double stepSizeValue,
             final TextView textView
@@ -430,6 +440,8 @@ private double getCurrentStepSize() {
                 .getFloat(getString(R.string.adjustment_step_key), (float) DEFAULT_STEP);
     }
 
+    // -- Additional options --
+
     private void setAndUpdateSkipSilence(final boolean newSkipSilence) {
         this.skipSilence = newSkipSilence;
         binding.skipSilenceCheckbox.setChecked(newSkipSilence);
@@ -461,6 +473,18 @@ private void bindCheckboxWithBoolPref(
         });
     }
 
+    /**
+     * Ensures that the slider hook is valid and if not sets and updates the sliders accordingly.
+     * <br/>
+     * You have to ensure by yourself that the hooking is active.
+     */
+    private void ensureHookIsValidAndUpdateCallBack() {
+        if (tempo != pitchPercent) {
+            setSliders(Math.min(tempo, pitchPercent));
+            updateCallback();
+        }
+    }
+
     /*//////////////////////////////////////////////////////////////////////////
     // Sliders
     //////////////////////////////////////////////////////////////////////////*/