fix(db): propagate changes through nested toArray includes at depth 3+ (#1457)

* fix(db): propagate changes through nested toArray includes at depth 3+

flushIncludesState only flushed entries dirty from direct child changes
(Phase 2) or single-level buffer drain (Phase 3). When only the deepest
level changed (e.g., textDeltas in runs→texts→textDeltas), intermediate
levels had no changes, so Phase 4 never triggered recursive flushing and
deep buffer changes were permanently stranded.

Add a third pass in Phase 4 that scans child registry entries for pending
deep nested buffer changes via hasPendingIncludesChanges(). Entries with
stranded buffers are recursively flushed and their correlation keys added
to the inline re-emit set.

Also prevent toArray()/concat(toArray()) from being silently wrapped as
Value nodes inside expressions like coalesce() — throw a clear error at
query construction time instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: add changeset for nested includes fix

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: apply automated fixes

* fix: resolve TypeScript errors in chained collection test

Remove explicit generic parameter from createLiveQueryCollection and use
`any` casts for query/select callbacks in the chained darix pattern test,
matching the style used in other test cases.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: move repro tests into existing includes.test.ts

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: 3 people

.changeset/fix-nested-includes-propagation.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/db': patch
+---
+
+Fix nested `toArray()` includes not propagating changes at depth 3+. When a query used nested includes like `toArray(runs) → toArray(texts) → concat(toArray(textDeltas))`, changes to the deepest level (e.g., inserting a textDelta) were silently lost because `flushIncludesState` only drained one level of nested buffers. Also throw a clear error when `toArray()` or `concat(toArray())` is used inside expressions like `coalesce()`, instead of silently producing incorrect results.

packages/db/src/query/builder/functions.ts

@@ -437,12 +437,14 @@ export const operators = [
 export type OperatorName = (typeof operators)[number]
 
 export class ToArrayWrapper<_T = unknown> {
+  readonly __brand = `ToArrayWrapper` as const
   declare readonly _type: `toArray`
   declare readonly _result: _T
   constructor(public readonly query: QueryBuilder<any>) {}
 }
 
 export class ConcatToArrayWrapper<_T = unknown> {
+  readonly __brand = `ConcatToArrayWrapper` as const
   declare readonly _type: `concatToArray`
   declare readonly _result: _T
   constructor(public readonly query: QueryBuilder<any>) {}

packages/db/src/query/builder/ref-proxy.ts

@@ -284,15 +284,31 @@ export function createRefProxyWithSelected<T extends Record<string, any>>(
 }
 
 /**
- * Converts a value to an Expression
- * If it's a RefProxy, creates a Ref, otherwise creates a Value
+ * Converts a value to an Expression.
+ * If it's a RefProxy, creates a PropRef. Throws if the value is a
+ * ToArrayWrapper or ConcatToArrayWrapper (these must be used as direct
+ * select fields). Otherwise wraps it as a Value.
  */
 export function toExpression<T = any>(value: T): BasicExpression<T>
 export function toExpression(value: RefProxy<any>): BasicExpression<any>
 export function toExpression(value: any): BasicExpression<any> {
   if (isRefProxy(value)) {
     return new PropRef(value.__path)
   }
+  // toArray() and concat(toArray()) must be used as direct select fields, not inside expressions
+  if (
+    value &&
+    typeof value === `object` &&
+    (value.__brand === `ToArrayWrapper` ||
+      value.__brand === `ConcatToArrayWrapper`)
+  ) {
+    const name =
+      value.__brand === `ToArrayWrapper` ? `toArray()` : `concat(toArray())`
+    throw new Error(
+      `${name} cannot be used inside expressions (e.g., coalesce(), eq(), not()). ` +
+        `Use ${name} directly as a select field value instead.`,
+    )
+  }
   // If it's already an Expression (Func, Ref, Value) or Agg, return it directly
   if (
     value &&

packages/db/src/query/live/collection-config-builder.ts

@@ -1699,6 +1699,30 @@ function flushIncludesState(
         )
       }
     }
+    // Finally: entries with deep nested buffer changes (grandchild-or-deeper buffers
+    // have pending data, but neither this level nor the immediate child level changed).
+    // Without this pass, changes at depth 3+ are stranded because drainNestedBuffers
+    // only drains one level and Phase 4 only flushes entries dirty from Phase 2/3.
+    const deepBufferDirty = new Set<unknown>()
+    if (state.nestedSetups) {
+      for (const [correlationKey, entry] of state.childRegistry) {
+        if (entriesWithChildChanges.has(correlationKey)) continue
+        if (dirtyFromBuffers.has(correlationKey)) continue
+        if (
+          entry.includesStates &&
+          hasPendingIncludesChanges(entry.includesStates)
+        ) {
+          flushIncludesState(
+            entry.includesStates,
+            entry.collection,
+            entry.collection.id,
+            null,
+            entry.syncMethods,
+          )
+          deepBufferDirty.add(correlationKey)
+        }
+      }
+    }
 
     // For inline materializations: re-emit affected parents with updated snapshots.
     // We mutate items in-place (so collection.get() reflects changes immediately)
@@ -1707,7 +1731,11 @@ function flushIncludesState(
     // deepEquals, but in-place mutation means both sides reference the same
     // object, so the comparison always returns true and suppresses the event.
     const inlineReEmitKeys = materializesInline(state)
-      ? new Set([...(affectedCorrelationKeys || []), ...dirtyFromBuffers])
+      ? new Set([
+          ...(affectedCorrelationKeys || []),
+          ...dirtyFromBuffers,
+          ...deepBufferDirty,
+        ])
       : null
     if (parentSyncMethods && inlineReEmitKeys && inlineReEmitKeys.size > 0) {
       const events: Array<ChangeMessage<any>> = []