fix: 修改模型层的实例方法为类方法

Author: colorful3

app/api/v1/book.py

@@ -22,42 +22,42 @@
 @login_required
 @Notify(template='{user.nickname}查询了一本图书', event='queryBook')
 def get_book(bid):
-    book = Book().get_detail(bid)
+    book = Book.get_detail(bid)
     return jsonify(book)
 
 
 @book_api.route('/', methods=['GET'])
 @login_required
 @Notify(template='{user.nickname}查询了所有图书', event='queryBooks')
 def get_books():
-    books = Book().get_all()
+    books = Book.get_all()
     return jsonify(books)
 
 
 @book_api.route('/search', methods=['GET'])
 def search():
     form = BookSearchForm().validate_for_api()
-    books = Book().search_by_keywords(form.q.data)
+    books = Book.search_by_keywords(form.q.data)
     return jsonify(books)
 
 
 @book_api.route('/', methods=['POST'])
 def create_book():
     form = CreateOrUpdateBookForm().validate_for_api()
-    Book().new_book(form)
+    Book.new_book(form)
     return Success(msg='新建图书成功')
 
 
 @book_api.route('/<bid>', methods=['PUT'])
 def update_book(bid):
     form = CreateOrUpdateBookForm().validate_for_api()
-    Book().edit_book(bid, form)
+    Book.edit_book(bid, form)
     return Success(msg='更新图书成功')
 
 
 @book_api.route('/<bid>', methods=['DELETE'])
 @route_meta(auth='删除图书', module='图书')
 @group_required
 def delete_book(bid):
-    Book().remove_book(bid)
+    Book.remove_book(bid)
     return Success(msg='删除图书成功')

app/models/book.py

@@ -16,39 +16,44 @@ class Book(Base):
     summary = Column(String(1000))
     image = Column(String(50))
 
-    def get_detail(self, bid):
-        book = self.query.filter_by(id=bid, delete_time=None).first()
+    @classmethod
+    def get_detail(cls, bid):
+        book = cls.query.filter_by(id=bid, delete_time=None).first()
         if book is None:
             raise NotFound(msg='没有找到相关书籍')
         return book
 
-    def get_all(self):
-        books = self.query.filter_by(delete_time=None).all()
+    @classmethod
+    def get_all(cls):
+        books = cls.query.filter_by(delete_time=None).all()
         if not books:
             raise NotFound(msg='没有找到相关书籍')
         return books
 
-    def search_by_keywords(self, q):
-        books = self.query.filter(Book.title.like('%' + q + '%'), Book.delete_time == None).all()
+    @classmethod
+    def search_by_keywords(cls, q):
+        books = cls.query.filter(Book.title.like('%' + q + '%'), Book.delete_time == None).all()
         if not books:
             raise BookNotFound()
         return books
 
-    def new_book(self, form):
+    @classmethod
+    def new_book(cls, form):
         book = Book.query.filter_by(title=form.title.data, delete_time=None).first()
         if book is not None:
             raise ParameterException(msg='图书已存在')
 
-        self.create(
+        Book.create(
             title=form.title.data,
             author=form.author.data,
             summary=form.summary.data,
             image=form.image.data,
             commit=True
         )
-        return self
+        return True
 
-    def edit_book(self, bid, form):
+    @classmethod
+    def edit_book(cls, bid, form):
         book = Book.query.filter_by(id=bid, delete_time=None).first()
         if book is None:
             raise NotFound(msg='没有找到相关书籍')
@@ -61,12 +66,13 @@ def edit_book(self, bid, form):
             image=form.image.data,
             commit=True
         )
-        return self
+        return True
 
-    def remove_book(self, bid):
-        book = self.query.filter_by(id=bid, delete_time=None).first()
+    @classmethod
+    def remove_book(cls, bid):
+        book = cls.query.filter_by(id=bid, delete_time=None).first()
         if book is None:
             raise NotFound(msg='没有找到相关书籍')
         # 删除图书，软删除
         book.delete(commit=True)
-        return self
+        return True