Update docstrings for observer to work with sphinx. Clearly distinguish between constructor args and attributes assigned based on those args (and 'locations' and 'times' which can be both)

Author: kysolvik

dabench/observer/_observer.py

@@ -19,7 +19,7 @@
 class Observer():
     """Base class for Observer objects
 
-    Attributes:
+    Args:
         data_obj: Data generator/loader object from which
             to gather observations.
         random_location_density: Fraction of locations in
@@ -74,6 +74,16 @@ class Observer():
         store_as_jax: Store values as jax array instead of numpy array.
             Default is False (store as numpy).
 
+    Attributes:
+        locations (ArrayLike): Location indices for making
+            observations. In system_dim (1D) or original dim
+            (>1D) of self.state_vec.
+        location_dim (int): Number of locations sampled from (max
+            in a single time step, if non-stationary observers).
+        times (ArrayLike): Time indices to gather observations
+            from.
+        time_dim (int): Number of times sampled from.
+
     """
 
     def __init__(self,
@@ -353,4 +363,4 @@ def observe(self) -> xr.Dataset:
             obs_vec[data_var] = obs_vec[data_var] + obs_vec['errors'].sel(variable=data_var)
 
 
-        return obs_vec
+        return obs_vec