Skip to content

Commit a5c01e5

Browse files
committed
Fix samplers for root sig 1.1 in EZ
1. Fix error interpretation for D3DX12SerializeVersionedRootSignature 2. Fix samplers for root signature 1.1 in EZ
1 parent 1117675 commit a5c01e5

7 files changed

Lines changed: 6 additions & 12 deletions

File tree

XUSG-EZ/XUSG-EZ_DX12.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ bool EZ::CommandList_DX12::createGraphicsPipelineLayouts(
764764

765765
if (stageMaxSamplers > 0)
766766
{
767-
pipelineLayout->SetRange(paramIndex, DescriptorType::SAMPLER, stageMaxSamplers, 0, 0, DescriptorFlag::DATA_STATIC);
767+
pipelineLayout->SetRange(paramIndex, DescriptorType::SAMPLER, stageMaxSamplers, 0);
768768
pipelineLayout->SetShaderStage(paramIndex++, stage);
769769
}
770770
}
@@ -846,7 +846,7 @@ bool EZ::CommandList_DX12::createComputePipelineLayouts(uint32_t maxSamplers,
846846
m_computeSpaceToParamIndexMap[static_cast<uint32_t>(DescriptorType::SRV)].resize(maxSrvSpaces);
847847
m_computeSpaceToParamIndexMap[static_cast<uint32_t>(DescriptorType::UAV)].resize(maxUavSpaces);
848848

849-
pipelineLayout->SetRange(paramIndex++, DescriptorType::SAMPLER, maxSamplers, 0, 0, DescriptorFlag::DATA_STATIC);
849+
pipelineLayout->SetRange(paramIndex++, DescriptorType::SAMPLER, maxSamplers, 0);
850850

851851
for (auto s = 0u; s < maxSpaces; ++s)
852852
{

XUSG-EZ/XUSGUltimate-EZ_DX12.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ bool EZ::CommandList_DX12::createMeshShaderPipelineLayouts(
225225

226226
if (stageMaxSamplers > 0)
227227
{
228-
pipelineLayout->SetRange(paramIndex, DescriptorType::SAMPLER, stageMaxSamplers, 0, 0, DescriptorFlag::DATA_STATIC);
228+
pipelineLayout->SetRange(paramIndex, DescriptorType::SAMPLER, stageMaxSamplers, 0);
229229
pipelineLayout->SetShaderStage(paramIndex++, stage);
230230
}
231231
}

XUSG/Core/XUSG.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,3 @@ uint8_t XUSG::CalculateMipLevels(uint64_t width, uint32_t height, uint32_t depth
395395
{
396396
return CalculateMipLevels(static_cast<uint32_t>(width), height, depth);
397397
}
398-
399-
uint32_t XUSG::CalculateSubresource(uint8_t mipSlice, uint8_t numMips, uint32_t arraySlice, uint32_t arraySize, uint8_t planeSlice)
400-
{
401-
return mipSlice + arraySlice * numMips + planeSlice * numMips * arraySize;
402-
}

XUSG/Core/XUSG.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2317,5 +2317,4 @@ namespace XUSG
23172317
XUSG_INTERFACE uint8_t Log2(uint32_t value);
23182318
XUSG_INTERFACE uint8_t CalculateMipLevels(uint32_t width, uint32_t height, uint32_t depth = 1);
23192319
XUSG_INTERFACE uint8_t CalculateMipLevels(uint64_t width, uint32_t height, uint32_t depth = 1);
2320-
XUSG_INTERFACE uint32_t CalculateSubresource(uint8_t mipSlice, uint8_t numMips, uint32_t arraySlice, uint32_t arraySize, uint8_t planeSlice);
23212320
}

XUSG/Core/XUSGPipelineLayout_DX12.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ PipelineLayout PipelineLayoutLib_DX12::createPipelineLayout(const string& key, c
370370

371371
com_ptr<ID3DBlob> signature, error;
372372
H_RETURN(D3DX12SerializeVersionedRootSignature(&rootSignatureDesc, highestVersion, signature.put(), error.put()),
373-
cerr, reinterpret_cast<wchar_t*>(error->GetBufferPointer()), nullptr);
373+
cerr, reinterpret_cast<char*>(error->GetBufferPointer()), nullptr);
374374

375375
return createRootSignature(key, signature->GetBufferPointer(), signature->GetBufferSize(), name, nodeMask);
376376
}

XUSGRayTracing-EZ/XUSGRayTracing-EZ_DX12.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ bool EZ::CommandList_DXR::createComputePipelineLayouts(uint32_t maxSamplers, con
372372
m_computeSpaceToParamIndexMap[static_cast<uint32_t>(DescriptorType::UAV)].resize(maxUavSpaces);
373373
m_tlasBindingToParamIndexMap.resize(maxTLASSrvs);
374374

375-
pipelineLayout->SetRange(paramIndex++, DescriptorType::SAMPLER, maxSamplers, 0, 0, DescriptorFlag::DATA_STATIC);
375+
pipelineLayout->SetRange(paramIndex++, DescriptorType::SAMPLER, maxSamplers, 0);
376376

377377
for (auto s = 0u; s < maxSpaces; ++s)
378378
{

XUSGRayTracing/RayTracing/XUSGRayTracingPipelineLayout_DX12.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ XUSG::PipelineLayout RayTracing::PipelineLayout_DX12::CreatePipelineLayout(const
7979
com_ptr<ID3DBlob> signature, error;
8080
const auto pDxDevice = static_cast<ID3D12RaytracingFallbackDevice*>(pDevice->GetRTHandle());
8181
H_RETURN(pDxDevice->D3D12SerializeVersionedRootSignature(&rootSignatureDesc, &signature, &error,
82-
AccelerationStructure::GetUAVCount()), cerr, reinterpret_cast<wchar_t*>(error->GetBufferPointer()), nullptr);
82+
AccelerationStructure::GetUAVCount()), cerr, reinterpret_cast<char*>(error->GetBufferPointer()), nullptr);
8383

8484
V_RETURN(pDxDevice->CreateRootSignature(1, signature->GetBufferPointer(), signature->GetBufferSize(),
8585
IID_PPV_ARGS(&rootSignature)), cerr, nullptr);

0 commit comments

Comments
 (0)