SONARJAVA-4682 Fix quickfix edits parsing

Fix a problem where the expectations parser would pick the first pair of
closing accolades "}}" in the edit as the end of the quick fix edit preventing the
use of these characters as part of the edits.

Author: dorian-burihabwa-sonarsource

java-checks-testkit/src/main/java/org/sonar/java/checks/verifier/internal/Expectations.java

@@ -645,7 +645,15 @@ private static Map.Entry<IssueAttribute, Object> parseAttribute(String attribute
     }
 
     private static String parseMessage(String cleanedComment, int horizon) {
-      return StringUtils.substringBetween(cleanedComment.substring(0, horizon), "{{", "}}");
+      String delimitedComment = cleanedComment.substring(0, horizon);
+      int firstIndex =  delimitedComment.indexOf("{{");
+      if (firstIndex != -1) {
+        int lastIndex = delimitedComment.lastIndexOf("}}");
+        if (lastIndex != -1) {
+          return delimitedComment.substring(firstIndex + 2, lastIndex);
+        }
+      }
+      return null;
     }
 
     static class ParsedComment {

java-checks-testkit/src/test/java/org/sonar/java/checks/verifier/internal/ExpectationsTest.java

@@ -374,6 +374,15 @@ private void assertJavaQuickFix(JavaQuickFix quickFix, String editTextSpan) {
       assertThat(textSpan).hasToString(editTextSpan);
     }
 
+    @Test
+    void quick_fix_edit_fails_without_end_delimiter() {
+      parser.parseIssue("// Noncompliant@ [[sc=3;ec=10;quickfixes=qf1]]", TEST_LINE);
+      parser.parseQuickFix("// fix@qf1 {{It goes like this:}}", TEST_LINE + 1);
+      parser.parseQuickFix("// edit@qf1 [[sc=5;ec=10]] {{boom}", TEST_LINE + 2);
+      assertThatThrownBy(() -> parser.consolidateQuickFixes())
+        .isInstanceOf(AssertionError.class);
+    }
+
     @Test
     void quick_fix_without_message() {
       parser.parseIssue("// Noncompliant@+1 [[sc=5;ec=10;quickfixes=qf1]]", TEST_LINE);