SONARJAVA-1285 Enable JavaCheckVerifier effortToFix and precise location assertions

Author: mpaladin

java-checks/src/test/files/checks/ClassComplexityNoncompliant.java

@@ -1,10 +1,10 @@
-public class HelloWorld { // Noncompliant {{The Cyclomatic Complexity of this class is 4 which is greater than 1 authorized.}}
+public class HelloWorld { // Noncompliant [[effortToFix=3]] {{The Cyclomatic Complexity of this class is 4 which is greater than 1 authorized.}}
 
   public void sayHello() {
     while (false) {
     }
   }
-  HelloWorld helloWorld = new HelloWorld() { // Noncompliant
+  HelloWorld helloWorld = new HelloWorld() { // Noncompliant [[effortToFix=1]]
     @Override
     public void sayHello() {
       while (false){

java-checks/src/test/files/checks/MethodComplexityNoncompliant.java

@@ -1,6 +1,6 @@
 public class HelloWorld {
 
-  public void sayHello() { // Noncompliant {{The Cyclomatic Complexity of this method "sayHello" is 2 which is greater than 1 authorized.}}
+  public void sayHello() { // Noncompliant [[effortToFix=1]] {{The Cyclomatic Complexity of this method "sayHello" is 2 which is greater than 1 authorized.}}
     while (false) {
     }
   }

java-checks/src/test/files/checks/SystemExitCalledCheck.java

@@ -1,11 +1,11 @@
 class A {
   void f() {
     System.exit(0);          // Noncompliant {{Remove this call to "exit" or ensure it is really required.}}
-    int a = System.exit(0);  // Noncompliant {{Remove this call to "exit" or ensure it is really required.}}
+    int a = System.exit(0);  // Noncompliant [[sc=13;ec=24]] {{Remove this call to "exit" or ensure it is really required.}}
     System.gc();             // Compliant
     System.exit[0];          // Compliant
     exit();                  // Compliant
-    Runtime.getRuntime().exit(); // Noncompliant {{Remove this call to "exit" or ensure it is really required.}}
+    Runtime.getRuntime().exit(); // Noncompliant [[sc=5;ec=30]] {{Remove this call to "exit" or ensure it is really required.}}
     Runtime.getRuntime().foo;    // Compliant
     Runtime.getRuntime().foo();  // Compliant
     Runtime.getRuntime()++;      // Compliant

java-checks/src/test/files/checks/SystemOutOrErrUsageCheck.java

@@ -2,12 +2,14 @@ class A {
 
   void f() {
     System.out.println("");                  // Noncompliant {{Replace this usage of System.out or System.err by a logger.}}
-    System.err.println("");                  // Noncompliant {{Replace this usage of System.out or System.err by a logger.}}
+    System.err.println("");                  // Noncompliant [[sc=5;ec=15]]
 
-    f(System.out);                           // Noncompliant {{Replace this usage of System.out or System.err by a logger.}}
+    f(System.out);                           // Noncompliant
 
     System.arraycopy(null, 0, null, 0, 0);   // Compliant
-    java.lang.System.out.println("");        // Noncompliant {{Replace this usage of System.out or System.err by a logger.}}
+    java.lang.System.out.println("");        // Noncompliant [[sc=5;ec=25]]
+    java.lang.                               // Noncompliant [[sc=5;el=+1;ec=17]]
+      System.out.println("");
   }
 
 }

java-checks/src/test/java/org/sonar/java/checks/ClassComplexityCheckTest.java

@@ -19,14 +19,8 @@
  */
 package org.sonar.java.checks;
 
-import org.sonar.java.checks.verifier.JavaCheckVerifier;
-import org.sonar.java.model.VisitorsBridge;
-import org.sonar.squidbridge.checks.CheckMessagesVerifier;
 import org.junit.Test;
-import org.sonar.java.ast.JavaAstScanner;
-import org.sonar.squidbridge.api.SourceFile;
-
-import java.io.File;
+import org.sonar.java.checks.verifier.JavaCheckVerifier;
 
 public class ClassComplexityCheckTest {
 
@@ -39,11 +33,7 @@ public void defaults() {
   public void test() {
     ClassComplexityCheck check = new ClassComplexityCheck();
     check.setMax(1);
-    SourceFile file = JavaAstScanner.scanSingleFile(new File("src/test/files/checks/ClassComplexityNoncompliant.java"), new VisitorsBridge(check));
-    CheckMessagesVerifier.verify(file.getCheckMessages())
-        .next().atLine(1).withMessage("The Cyclomatic Complexity of this class is 4 which is greater than 1 authorized.").withCost(3.0)
-        .next().atLine(7).withMessage("The Cyclomatic Complexity of this class is 2 which is greater than 1 authorized.").withCost(1.0)
-        .noMore();
+    JavaCheckVerifier.verify("src/test/files/checks/ClassComplexityNoncompliant.java", check);
   }
 
 }

java-checks/src/test/java/org/sonar/java/checks/SystemOutOrErrUsageCheckTest.java

@@ -24,7 +24,7 @@
 
 public class SystemOutOrErrUsageCheckTest {
   @Test
-  public void detected() {
+  public void test() {
     JavaCheckVerifier.verify("src/test/files/checks/SystemOutOrErrUsageCheck.java", new SystemOutOrErrUsageCheck());
   }
 }