Skip to content

Commit bf1c9a7

Browse files
committed
SONARJAVA-1385 Remove activation by default
1 parent 849b430 commit bf1c9a7

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

java-checks/src/main/java/org/sonar/java/checks/LoggersDeclarationCheck.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import org.sonar.plugins.java.api.tree.ModifiersTree;
3535
import org.sonar.plugins.java.api.tree.Tree;
3636
import org.sonar.plugins.java.api.tree.VariableTree;
37-
import org.sonar.squidbridge.annotations.ActivatedByDefault;
3837
import org.sonar.squidbridge.annotations.SqaleConstantRemediation;
3938
import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
4039

@@ -45,7 +44,6 @@
4544
name = "Loggers should be \"private static final\" and should share a naming convention",
4645
priority = Priority.MINOR,
4746
tags = {Tag.CONVENTION})
48-
@ActivatedByDefault
4947
@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.UNDERSTANDABILITY)
5048
@SqaleConstantRemediation("5min")
5149
public class LoggersDeclarationCheck extends BaseTreeVisitor implements JavaFileScanner {

sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaSonarWayProfileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public void should_create_sonar_way_profile() {
4747

4848
assertThat(profile.getLanguage()).isEqualTo(Java.KEY);
4949
List<ActiveRule> activeRules = profile.getActiveRulesByRepository(CheckList.REPOSITORY_KEY);
50-
assertThat(activeRules.size()).as("Expected number of rules in profile").isGreaterThan(220);
50+
assertThat(activeRules.size()).as("Expected number of rules in profile").isGreaterThanOrEqualTo(232);
5151
assertThat(profile.getName()).isEqualTo("Sonar way");
5252
assertThat(validation.hasErrors()).isFalse();
5353
}

0 commit comments

Comments
 (0)