SONARJAVA-5547 Fix S2699 for springframework.util.Assert (#5135)

Author: leonardo-pilastri-sonarsource

its/autoscan/src/test/resources/autoscan/diffs/diff_S2699.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2699",
   "hasTruePositives": true,
-  "falseNegatives": 154,
+  "falseNegatives": 155,
   "falsePositives": 1
 }

java-checks-test-sources/default/src/test/java/checks/tests/AssertionsInTestsCheck/SpringUtilAssertTestSample.java

@@ -0,0 +1,31 @@
+package checks.tests.AssertionsInTestsCheck;
+
+import java.net.http.HttpResponse;
+import org.junit.Test;
+import org.springframework.util.Assert;
+
+public class SpringUtilAssertTestSample {
+
+  HttpResponse<String> response;
+
+  @Test
+  public void test_with_no_assertions() { // Noncompliant
+    // no assertions
+  }
+
+  @org.junit.Test
+  public void test_spring_util_assert() {
+    org.springframework.util.Assert.isTrue(response.statusCode() == 200, "Expected 200 ");
+  }
+
+  @Test
+  public void test_spring_util_assert2() {
+    Assert.isNull(response, "Expected null but was not");
+  }
+
+  @Test
+  public void test_spring_util_assert3() {
+    Assert.hasLength(response.body(), "body should not be empty");
+  }
+
+}

java-checks/src/main/java/org/sonar/java/checks/helpers/UnitTestUtils.java

@@ -78,6 +78,7 @@ public final class UnitTestUtils {
       .name(ASSERTJ_ASSERTION_METHODS_PREDICATE).withAnyParameters().build(),
     // spring
     MethodMatchers.create().ofTypes("org.springframework.test.web.servlet.ResultActions").names("andExpect", "andExpectAll").withAnyParameters().build(),
+    MethodMatchers.create().ofTypes("org.springframework.util.Assert").anyName().withAnyParameters().build(),
     // JMockit
     MethodMatchers.create().ofTypes("mockit.Verifications").constructor().withAnyParameters().build(),
     // Eclipse Vert.x with JUnit 4

java-checks/src/test/java/org/sonar/java/checks/tests/AssertionsInTestsCheckTest.java

@@ -126,4 +126,12 @@ void testSpringBootAssertableApplicationContext(){
       .verifyIssues();
   }
 
+  @Test
+  void testSpringUtilAssert(){
+    CheckVerifier.newVerifier()
+      .onFile(testCodeSourcesPath("checks/tests/AssertionsInTestsCheck/SpringUtilAssertTestSample.java"))
+      .withCheck(check)
+      .verifyIssues();
+  }
+
 }