SONARJAVA-1430 Detect call to deprecated constructors

Author: benzonico

java-checks/src/main/java/org/sonar/java/checks/CallToDeprecatedMethodCheck.java

@@ -61,7 +61,7 @@ public List<Tree.Kind> nodesToVisit() {
   public void visitNode(Tree tree) {
     if (tree.is(Tree.Kind.IDENTIFIER)) {
       Symbol symbol = ((IdentifierTree) tree).symbol();
-      if (symbol.isDeprecated() && nestedDeprecationLevel == 0) {
+      if (isDeprecated(symbol) && nestedDeprecationLevel == 0) {
         String name;
         if (isConstructor(symbol)) {
           name = symbol.owner().name();
@@ -76,6 +76,10 @@ public void visitNode(Tree tree) {
 
   }
 
+  private static boolean isDeprecated(Symbol symbol) {
+    return symbol.isDeprecated() || (isConstructor(symbol) && symbol.owner().isDeprecated());
+  }
+
   private static boolean isConstructor(Symbol symbol) {
     return symbol.isMethodSymbol() && "<init>".equals(symbol.name());
   }

java-checks/src/test/files/checks/CallToDeprecatedMethod.java

@@ -6,7 +6,7 @@ public CallToDeprecatedMethodCheck() {
     String string = new String("my string");
     string.getBytes(1, 1, new byte[3], 7); // Noncompliant [[sc=12;ec=20]] {{Remove this use of "getBytes"; it is deprecated.}}
     new DeprecatedConstructor(); // Noncompliant [[sc=9;ec=30]] {{Remove this use of "DeprecatedConstructor"; it is deprecated.}}
-    new MyDeprecatedClass();
+    new MyDeprecatedClass(); // Noncompliant
     old++; // Noncompliant
     MyDeprecatedClass.a++; // Noncompliant
   }