Skip to content

Commit a596f66

Browse files
johann-beleites-sonarsourcejohann-beleites-sonarsource
authored
SONARJAVA-4940 Enable various main code rules on test code as well (#4774)
1 parent 975a191 commit a596f66

24 files changed

Lines changed: 908 additions & 13 deletions

File tree

‎its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S1874",
33
"hasTruePositives": true,
4-
"falseNegatives": 151,
4+
"falseNegatives": 246,
55
"falsePositives": 0
6-
}
6+
}

‎its/autoscan/src/test/resources/autoscan/diffs/diff_S4144.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S4144",
33
"hasTruePositives": true,
4-
"falseNegatives": 2,
4+
"falseNegatives": 3,
55
"falsePositives": 7
6-
}
6+
}

‎its/ruling/src/test/resources/commons-beanutils/java-S1172.json‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,33 @@
55
"commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils2/converters/AbstractConverter.java": [
66
454
77
],
8+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/A.java": [
9+
31
10+
],
11+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/AbstractParent.java": [
12+
34,
13+
41,
14+
51
15+
],
16+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BetaBean.java": [
17+
34
18+
],
19+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/LazyDynaListTestCase.java": [
20+
177
21+
],
22+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/MappedPropertyTestBean.java": [
23+
77
24+
],
25+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/TestBean.java": [
26+
434
27+
],
28+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/TestResultSet.java": [
29+
202,
30+
206,
31+
210,
32+
222
33+
],
34+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/memoryleaktests/MemoryLeakTestCase.java": [
35+
540
36+
]
837
}

‎its/ruling/src/test/resources/commons-beanutils/java-S1481.json‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,11 @@
22
"commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java": [
33
353
44
],
5+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java": [
6+
109,
7+
129,
8+
178,
9+
218,
10+
253
11+
]
512
}

‎its/ruling/src/test/resources/commons-beanutils/java-S1854.json‎

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,97 @@
88
"commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils2/WrapDynaClass.java": [
99
353
1010
],
11+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java": [
12+
106,
13+
107,
14+
153,
15+
154,
16+
234,
17+
236
18+
],
19+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java": [
20+
146
21+
],
22+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java": [
23+
537,
24+
548,
25+
559,
26+
570,
27+
581,
28+
592,
29+
603,
30+
614,
31+
625,
32+
636
33+
],
34+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/LazyDynaListTestCase.java": [
35+
296,
36+
454,
37+
455,
38+
479,
39+
480,
40+
504,
41+
505,
42+
529,
43+
530
44+
],
45+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/PropertyUtilsTestCase.java": [
46+
892,
47+
903,
48+
914,
49+
925,
50+
936,
51+
947,
52+
958,
53+
969,
54+
980,
55+
991,
56+
1002,
57+
1013,
58+
1811
59+
],
60+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/TestResultSetMetaData.java": [
61+
127
62+
],
63+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/bugs/Jira347TestCase.java": [
64+
117
65+
],
66+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java": [
67+
109,
68+
114,
69+
115,
70+
129,
71+
159,
72+
160,
73+
178,
74+
218,
75+
232,
76+
234,
77+
253
78+
],
79+
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/memoryleaktests/MemoryLeakTestCase.java": [
80+
84,
81+
85,
82+
86,
83+
133,
84+
134,
85+
135,
86+
230,
87+
231,
88+
232,
89+
281,
90+
282,
91+
283,
92+
329,
93+
330,
94+
331,
95+
332,
96+
382,
97+
383,
98+
384,
99+
430,
100+
431,
101+
432,
102+
495
103+
]
11104
}

‎its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S1144.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java": [
33
433
4-
],
4+
]
55
}

‎its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S1172.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,10 @@
1717
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionData.java": [
1818
240
1919
],
20+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/GracefulStopTest.java": [
21+
177
22+
],
23+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpWriterTest.java": [
24+
243
25+
]
2026
}

‎its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S1481.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/HttpCookieTest.java": [
3+
74
4+
],
5+
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/pathmap/WebSocketUriMappingTest.java": [
6+
91
7+
]
8+
}

‎its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S1854.json‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,62 @@
22
"org.eclipse.jetty:jetty-project:jetty-http/src/main/java/org/eclipse/jetty/http/QuotedCSVParser.java": [
33
193
44
],
5+
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/HttpCookieTest.java": [
6+
74,
7+
103
8+
],
9+
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/pathmap/WebSocketUriMappingTest.java": [
10+
91
11+
],
12+
"org.eclipse.jetty:jetty-project:jetty-io/src/test/java/org/eclipse/jetty/io/SslConnectionTest.java": [
13+
92,
14+
94,
15+
97,
16+
105,
17+
147,
18+
272
19+
],
20+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpOutputTest.java": [
21+
861
22+
],
23+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/LowResourcesMonitorTest.java": [
24+
183
25+
],
26+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/PartialRFC2616Test.java": [
27+
184,
28+
188,
29+
191,
30+
230,
31+
235,
32+
239,
33+
268,
34+
271,
35+
314,
36+
319,
37+
348,
38+
349,
39+
420,
40+
431,
41+
438,
42+
449,
43+
456,
44+
461,
45+
479,
46+
484,
47+
486,
48+
503,
49+
521,
50+
543,
51+
559,
52+
571,
53+
578,
54+
649,
55+
654,
56+
656,
57+
660,
58+
672,
59+
679,
60+
684,
61+
685
62+
]
563
}

‎its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S3457.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
2+
"org.eclipse.jetty:jetty-project:jetty-io/src/test/java/org/eclipse/jetty/io/SocketChannelEndPointTest.java": [
3+
429
4+
],
25
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/HomeBaseWarning.java": [
36
72
47
],
@@ -16,4 +19,12 @@
1619
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/ShutdownMonitor.java": [
1720
142
1821
],
22+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/AsyncStressTest.java": [
23+
117,
24+
146,
25+
158
26+
],
27+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java": [
28+
1209
29+
]
1930
}

0 commit comments

Comments
 (0)