SONARJAVA-6123 Issues for rule S8433 (#5463)

Author: asya-vorobeva

its/autoscan/src/test/java/org/sonar/java/it/AutoScanTest.java

@@ -199,7 +199,7 @@ public void javaCheckTestSources() throws Exception {
     softly.assertThat(newDiffs).containsExactlyInAnyOrderElementsOf(knownDiffs.values());
     softly.assertThat(newTotal).isEqualTo(knownTotal);
     softly.assertThat(rulesCausingFPs).hasSize(10);
-    softly.assertThat(rulesNotReporting).hasSize(16);
+    softly.assertThat(rulesNotReporting).hasSize(17);
 
     /**
      * 4. Check total number of differences (FPs + FNs)

its/autoscan/src/test/resources/autoscan/diffs/diff_S8433.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S8433",
-  "hasTruePositives": true,
+  "hasTruePositives": false,
   "falseNegatives": 0,
   "falsePositives": 0
 }

java-checks-test-sources/default/src/main/files/non-compiling/checks/FlexibleConstructorBodyValidationCheckSample.java

@@ -133,7 +133,7 @@ public SpringCoffee(String name) {
   static class ImplicitSuperCoffee extends Coffee {
     public ImplicitSuperCoffee(int water) {
       // Implicit super() call here
-      if (water < 0) { // Noncompliant
+      if (water < 0) {
         throw new IllegalArgumentException();
       }
     }
@@ -167,23 +167,4 @@ public NestedIfCoffee(int water, int milk) {
     }
   }
 
-  // Test when there is no superclass
-  static class NoSuperclassCoffee {
-    private int water;
-    private int milk;
-    private static final int MAX_SIZE = 500;
-
-    public NoSuperclassCoffee(int water, int milk) {
-      if (water + milk > MAX_SIZE) { // Compliant: no superclass and no this(...) call
-        throw new IllegalArgumentException();
-      }
-    }
-
-    public NoSuperclassCoffee(int water) {
-      this(water, 0);
-      if (water <= 0) { // Noncompliant {{Move this validation logic before the super() or this() call.}}
-        throw new IllegalArgumentException();
-      }
-    }
-  }
 }

java-checks/src/main/java/org/sonar/java/checks/FlexibleConstructorBodyValidationCheck.java

@@ -23,7 +23,6 @@
 import org.sonar.check.Rule;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;
 import org.sonar.plugins.java.api.semantic.Symbol;
-import org.sonar.plugins.java.api.semantic.Type;
 import org.sonar.plugins.java.api.tree.BaseTreeVisitor;
 import org.sonar.plugins.java.api.tree.ExpressionStatementTree;
 import org.sonar.plugins.java.api.tree.ExpressionTree;
@@ -65,8 +64,8 @@ public class FlexibleConstructorBodyValidationCheck extends FlexibleConstructorV
   @Override
   void validateConstructor(MethodTree constructor, List<StatementTree> body, int constructorCallIndex) {
     if (constructorCallIndex == body.size() - 1
-      || (constructorCallIndex == -1 && hasNoExplicitSuperClass(constructor))) {
-      // No statements after constructor call or no superclass and no constructor call
+      || (constructorCallIndex == -1)) {
+      // No statements after constructor call or no constructor call
       return;
     }
     // Collect constructor parameters for analysis
@@ -82,11 +81,6 @@ void validateConstructor(MethodTree constructor, List<StatementTree> body, int c
     }
   }
 
-  private static boolean hasNoExplicitSuperClass(MethodTree constructor) {
-    Type superClass = constructor.symbol().enclosingClass().superClass();
-    return (superClass == null || superClass.is("java.lang.Object"));
-  }
-
   /**
    * Check if a statement is a validation statement (conditionally throws exception or calls validation method).
    *