SONARJAVA-1297 Add precise location assertions in unit tests

Author: mpaladin

java-checks/src/test/files/checks/AssignmentInSubExpressionCheck.java

@@ -3,7 +3,7 @@ void foo() {
     int a = 0;                   // Compliant
     a = 0;                       // Compliant
     System.out.println(a);       // Compliant
-    System.out.println(a = 0);   // Noncompliant {{Extract the assignment out of this expression.}}
+    System.out.println(a = 0);   // Noncompliant [[sc=26;ec=27]] {{Extract the assignment out of this expression.}}
     System.out.println(a += 0);  // Noncompliant {{Extract the assignment out of this expression.}}
     System.out.println(a == 0);  // Compliant
 

java-checks/src/test/files/checks/BadFieldName.java

@@ -1,5 +1,5 @@
 class BadFieldName {
-  public int BAD_FIELD_NAME; // Noncompliant {{Rename this field "BAD_FIELD_NAME" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.}}
+  public int BAD_FIELD_NAME; // Noncompliant [[sc=14;ec=28]] {{Rename this field "BAD_FIELD_NAME" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.}}
   public int goodFieldName;
   public static int STATIC;
 

java-checks/src/test/files/checks/BadFieldNameStaticNonFinal.java

@@ -1,7 +1,7 @@
 class BadFieldName {
   public int BAD_FIELD_NAME;
   public int goodFieldName;
-  public static int BAD_FIELD_NAME_STATIC_NON_FINAL; // Noncompliant {{Rename this field "BAD_FIELD_NAME_STATIC_NON_FINAL" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.}}
+  public static int BAD_FIELD_NAME_STATIC_NON_FINAL; // Noncompliant [[sc=21;ec=52]] {{Rename this field "BAD_FIELD_NAME_STATIC_NON_FINAL" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.}}
   public static int goodFieldNameStaticNonFinal;
   public final static int STATIC; // Compliant, final modifier
 

java-checks/src/test/files/checks/CallToDeprecatedMethod.java

@@ -2,7 +2,7 @@ public class CallToDeprecatedMethodCheck {
 
   public CallToDeprecatedMethodCheck() {
     String string = new String("my string");
-    string.getBytes(1, 1, new byte[3], 7); // Noncompliant {{Method 'String.getBytes(...)' is deprecated.}}
+    string.getBytes(1, 1, new byte[3], 7); // Noncompliant [[sc=5;ec=20]] {{Method 'String.getBytes(...)' is deprecated.}}
     new DeprecatedConstructor(); // Noncompliant {{Constructor 'DeprecatedConstructor(...)' is deprecated.}}
     new MyDeprecatedClass();
   }

java-checks/src/test/files/checks/ClassVariableVisibilityCheck.java

@@ -4,7 +4,7 @@ class Foo {
   private int foo1;
   int foo2;
   protected int foo3;
-  public int foo4; // Noncompliant {{Make foo4 a static final constant or non-public and provide accessors if needed.}}
+  public int foo4; // Noncompliant [[sc=14;ec=18]] {{Make foo4 a static final constant or non-public and provide accessors if needed.}}
 
   public static int foo5; // Noncompliant {{Make foo5 a static final constant or non-public and provide accessors if needed.}}
   public final int foo6; // Compliant
@@ -27,4 +27,4 @@ static interface blah {
 interface bar {
   public int blah = 0;
 
-}
+}

java-checks/src/test/files/checks/CompareObjectWithEqualsCheck.java

@@ -4,7 +4,7 @@ class A {
   String[] strArray1 = {"blue"};
   String[] strArray2 = {"blue"};
   private void method() {
-    if (str1 == str2) {} // Noncompliant {{Change this comparison to use the equals method.}}
+    if (str1 == str2) {} // Noncompliant [[sc=14;ec=16]] {{Change this comparison to use the equals method.}}
     if(str1 == "green") {} // Noncompliant {{Change this comparison to use the equals method.}}
     if (str1.equals(str2)) {}
     if(strArray1 == strArray2) {}

java-checks/src/test/files/checks/EmptyMethodsCheck.java

@@ -1,5 +1,5 @@
 class A {
-  // Noncompliant@+1
+  // Noncompliant@+1 [[sc=10;ec=11]]
   public A() {
   }
 

java-checks/src/test/files/checks/OneDeclarationPerLineCheck.java

@@ -1,5 +1,5 @@
 interface MyInterface {
-  int a = 1, b = 1; // Noncompliant {{Declare "b" on a separate line.}}
+  int a = 1, b = 1; // Noncompliant [[sc=14;ec=15]] {{Declare "b" on a separate line.}}
 }
 
 enum MyEnum {

java-checks/src/test/files/checks/RightCurlyBraceDifferentLineAsNextBlockCheck.java

@@ -2,7 +2,7 @@ class Foo {
   public void myMethod() {
     if(something) {
       executeTask();
-    } else if (somethingElse) {          // Noncompliant {{Move this "else" keyword to a new dedicated line.}}
+    } else if (somethingElse) {          // Noncompliant [[sc=7;ec=11]] {{Move this "else" keyword to a new dedicated line.}}
       doSomethingElse();
     }
     else {                               // Compliant

java-checks/src/test/files/checks/RightCurlyBraceSameLineAsNextBlockCheck.java

@@ -5,7 +5,7 @@ public void myMethod() {
     } else if (somethingElse) {          // Compliant
       doSomethingElse();
     }
-    else {                               // Noncompliant {{Move this "else" on the same line that the previous closing curly brace.}}
+    else {                               // Noncompliant [[sc=5;ec=9]] {{Move this "else" on the same line that the previous closing curly brace.}}
        generateError();
     }