Skip to content

Commit 9100ff1

Browse files
committed
SONARJAVA-1440 Drop deprecated complexty methods.
1 parent 8c2dfda commit 9100ff1

3 files changed

Lines changed: 0 additions & 54 deletions

File tree

java-squid/src/main/java/org/sonar/java/model/DefaultJavaFileScannerContext.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -149,16 +149,6 @@ public File getFile() {
149149
return file;
150150
}
151151

152-
@Override
153-
public int getComplexity(Tree tree) {
154-
return getComplexityNodes(tree).size();
155-
}
156-
157-
@Override
158-
public int getMethodComplexity(ClassTree enclosingClass, MethodTree methodTree) {
159-
return getMethodComplexityNodes(enclosingClass, methodTree).size();
160-
}
161-
162152
@Override
163153
public List<Tree> getComplexityNodes(Tree tree) {
164154
return complexityVisitor.scan(tree);

java-squid/src/main/java/org/sonar/plugins/java/api/JavaFileScannerContext.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,6 @@ public interface JavaFileScannerContext {
6666

6767
boolean fileParsed();
6868

69-
/**
70-
* @deprecated As of release 3.6, replaced by {@link #getComplexityNodes(Tree)}
71-
*/
72-
@Deprecated
73-
int getComplexity(Tree tree);
74-
75-
/**
76-
* @deprecated As of release 3.6, replaced by {@link #getMethodComplexityNodes(ClassTree, MethodTree)}
77-
*/
78-
@Deprecated
79-
int getMethodComplexity(ClassTree enclosingClass, MethodTree methodTree);
80-
8169
List<Tree> getComplexityNodes(Tree tree);
8270

8371
List<Tree> getMethodComplexityNodes(ClassTree enclosingClass, MethodTree methodTree);

java-squid/src/test/java/org/sonar/java/model/InternalVisitorsBridgeTest.java

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,12 @@
2929
import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
3030
import org.sonar.plugins.java.api.JavaFileScanner;
3131
import org.sonar.plugins.java.api.JavaFileScannerContext;
32-
import org.sonar.plugins.java.api.tree.ClassTree;
3332
import org.sonar.plugins.java.api.tree.CompilationUnitTree;
34-
import org.sonar.plugins.java.api.tree.MethodTree;
3533
import org.sonar.plugins.java.api.tree.Tree;
3634
import org.sonar.plugins.java.api.tree.Tree.Kind;
3735
import org.sonar.squidbridge.api.SourceProject;
3836

3937
import javax.annotation.Nullable;
40-
4138
import java.io.File;
4239
import java.util.Collections;
4340
import java.util.List;
@@ -63,35 +60,6 @@ public void scanFile(JavaFileScannerContext context) {
6360
checkFile(contstructFileName("home", "user", "oracleSdk", "java", "lang", "someFile.java"), "package java.lang; class A {}", visitorsBridgeWithoutSemantic);
6461
checkFile(contstructFileName("java", "io", "Serializable.java"), "package java.io; class A {}", visitorsBridgeWithoutSemantic);
6562
checkFile(contstructFileName("java", "lang", "annotation", "Annotation.java"), "package java.lang.annotation; class Annotation {}", visitorsBridgeWithoutSemantic);
66-
InternalVisitorsBridge visitorsBridgeWithSemantic = new InternalVisitorsBridge(Collections.singletonList(new IssuableSubscriptionVisitor() {
67-
public ClassTree enclosingClass;
68-
69-
@Override
70-
public List<Tree.Kind> nodesToVisit() {
71-
return ImmutableList.of(Tree.Kind.CLASS, Tree.Kind.METHOD);
72-
}
73-
74-
@Override
75-
public void scanFile(JavaFileScannerContext context) {
76-
assertThat(context.getSemanticModel()).isNotNull();
77-
assertThat(context.fileParsed()).isTrue();
78-
super.scanFile(context);
79-
}
80-
81-
@Override
82-
public void visitNode(Tree tree) {
83-
if (tree.is(Tree.Kind.CLASS)) {
84-
enclosingClass = (ClassTree) tree;
85-
assertThat(context.getComplexityNodes(enclosingClass).size()).isEqualTo(context.getComplexity(enclosingClass));
86-
} else {
87-
assertThat(context.getMethodComplexityNodes(enclosingClass, ((MethodTree) tree)).size()).isEqualTo(context.getMethodComplexity(enclosingClass, ((MethodTree) tree)));
88-
}
89-
}
90-
}), Lists.<File>newArrayList(), null);
91-
visitorsBridgeWithSemantic.setContext(context);
92-
checkFile(contstructFileName("java", "lang", "annotation", "Foo.java"), "package java.lang.annotation; class Annotation {}", visitorsBridgeWithSemantic);
93-
checkFile(contstructFileName("java", "io", "File.java"), "package java.io; class A {}", visitorsBridgeWithSemantic);
94-
checkFile(contstructFileName("src", "foo", "bar", "java", "lang", "someFile.java"), "package foo.bar.java.lang; class A { void method() { ; } }", visitorsBridgeWithSemantic);
9563

9664
InternalVisitorsBridge visitorsBridgeWithParsingIssue = new InternalVisitorsBridge(Collections.singletonList(new IssuableSubscriptionVisitor() {
9765
@Override

0 commit comments

Comments
 (0)