SONARJAVA-1515 Make call to system exit sink of execution

Author: benzonico

java-frontend/src/main/java/org/sonar/java/se/ExplodedGraphWalker.java

@@ -30,6 +30,7 @@
 import org.slf4j.LoggerFactory;
 import org.sonar.java.cfg.CFG;
 import org.sonar.java.cfg.LiveVariables;
+import org.sonar.java.matcher.MethodMatcher;
 import org.sonar.java.model.JavaTree;
 import org.sonar.java.se.checks.ConditionAlwaysTrueOrFalseCheck;
 import org.sonar.java.se.checks.LocksNotUnlockedCheck;
@@ -89,6 +90,7 @@ public class ExplodedGraphWalker extends BaseTreeVisitor {
 
   private static final boolean DEBUG_MODE_ACTIVATED = false;
   private static final int MAX_EXEC_PROGRAM_POINT = 2;
+  private static final MethodMatcher SYSTEM_EXIT_MATCHER = MethodMatcher.create().typeDefinition("java.lang.System").name("exit").addParameter("int");
   private final ConditionAlwaysTrueOrFalseCheck alwaysTrueOrFalseChecker;
   private MethodTree methodTree;
   private ExplodedGraph explodedGraph;
@@ -353,7 +355,12 @@ private void visit(Tree tree, @Nullable Tree terminator) {
     }
     switch (tree.kind()) {
       case METHOD_INVOCATION:
-        executeMethodInvocation((MethodInvocationTree) tree);
+        MethodInvocationTree mit = (MethodInvocationTree) tree;
+        if(SYSTEM_EXIT_MATCHER.matches(mit)) {
+          //System exit is a sink of execution
+          return;
+        }
+        executeMethodInvocation(mit);
         break;
       case LABELED_STATEMENT:
       case SWITCH_STATEMENT:

java-frontend/src/test/files/se/SystemExit.java

@@ -0,0 +1,17 @@
+class A {
+  void foo() {
+    boolean a = true;
+    System.exit(-1);
+    if (a) {
+
+    }
+  }
+
+  void bar(boolean a) {
+    if (a) {
+      System.exit(-1);
+    }
+    if(a) { // Noncompliant {{Change this condition so that it does not always evaluate to "false"}}
+    }
+  }
+}

java-frontend/src/test/java/org/sonar/java/se/ExplodedGraphWalkerTest.java

@@ -118,6 +118,12 @@ public void visitNode(Tree tree) {
     });
   }
 
+
+  @Test
+  public void system_exit() throws Exception {
+    JavaCheckVerifier.verify("src/test/files/se/SystemExit.java", new IssueVisitor());
+  }
+
   class IssueVisitor implements JavaFileScanner {
 
     @Override