All java7/8 compatible checks executed when source version is not set

Author: Wohops

java-checks/src/main/java/org/sonar/java/checks/AbstractClassNoFieldShouldBeInterfaceCheck.java

@@ -50,7 +50,7 @@ public class AbstractClassNoFieldShouldBeInterfaceCheck extends IssuableSubscrip
 
   @Override
   public boolean isCompatibleWithJavaVersion(Integer version) {
-    return JavaVersionHelper.java8Guaranteed(version);
+    return JavaVersionHelper.java8Compatible(version);
   }
 
   @Override
@@ -62,7 +62,9 @@ public List<Tree.Kind> nodesToVisit() {
   public void visitNode(Tree tree) {
     ClassTree classTree = (ClassTree) tree;
     if (classTree.superClass() == null && classIsAbstract(classTree) && classHasNoFieldAndProtectedMethod(classTree)) {
-      addIssue(classTree, "Convert the abstract class \"" + classTree.simpleName().name() + "\" into an interface.");
+      addIssue(
+        classTree,
+        "Convert the abstract class \"" + classTree.simpleName().name() + "\" into an interface." + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
     }
   }
 

java-checks/src/main/java/org/sonar/java/checks/AnonymousClassShouldBeLambdaCheck.java

@@ -41,6 +41,7 @@
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
 
 import javax.annotation.Nullable;
+
 import java.util.List;
 
 @Rule(
@@ -58,7 +59,7 @@ public class AnonymousClassShouldBeLambdaCheck extends BaseTreeVisitor implement
 
   @Override
   public boolean isCompatibleWithJavaVersion(@Nullable Integer version) {
-    return JavaVersionHelper.java8Guaranteed(version);
+    return JavaVersionHelper.java8Compatible(version);
   }
 
   @Override
@@ -82,7 +83,7 @@ public void visitNewClass(NewClassTree tree) {
     if (classBody != null) {
       TypeTree identifier = tree.identifier();
       if (!useThisIdentifier(classBody) && !enumConstants.contains(identifier) && hasOnlyOneMethod(classBody.members())) {
-        context.addIssue(identifier, this, "Make this anonymous inner class a lambda");
+        context.addIssue(identifier, this, "Make this anonymous inner class a lambda" + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
       }
     }
   }

java-checks/src/main/java/org/sonar/java/checks/DateUtilsTruncateCheck.java

@@ -34,6 +34,7 @@
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
 
 import javax.annotation.Nullable;
+
 import java.util.List;
 
 @Rule(
@@ -48,7 +49,7 @@ public class DateUtilsTruncateCheck extends AbstractMethodDetection implements J
 
   @Override
   public boolean isCompatibleWithJavaVersion(@Nullable Integer version) {
-    return JavaVersionHelper.java8Guaranteed(version);
+    return JavaVersionHelper.java8Compatible(version);
   }
 
   @Override
@@ -61,7 +62,7 @@ protected List<MethodMatcher> getMethodInvocationMatchers() {
 
   @Override
   protected void onMethodInvocationFound(MethodInvocationTree mit) {
-    addIssue(mit, "Use \"Instant.truncatedTo\" instead.");
+    addIssue(mit, "Use \"Instant.truncatedTo\" instead." + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
   }
 
   private static MethodMatcher truncateMethodMatcher(String firstParameterType) {

java-checks/src/main/java/org/sonar/java/checks/DiamondOperatorCheck.java

@@ -62,7 +62,7 @@ public class DiamondOperatorCheck extends SubscriptionBaseVisitor implements Jav
 
   @Override
   public boolean isCompatibleWithJavaVersion(Integer version) {
-    return JavaVersionHelper.java7Guaranteed(version);
+    return JavaVersionHelper.java7Compatible(version);
   }
 
   @Override
@@ -77,7 +77,10 @@ public void visitNode(Tree tree) {
     if (newClassTree.classBody() == null && isParameterizedType(newTypeTree)) {
       TypeTree type = getTypeFromExpression(tree.parent());
       if (type != null && isParameterizedType(type)) {
-        reportIssue(((ParameterizedTypeTree) newTypeTree).typeArguments(), "Replace the type specification in this constructor call.");
+        reportIssue(
+          ((ParameterizedTypeTree) newTypeTree).typeArguments(),
+          "Replace the type specification in this constructor call with the diamond operator (\"<>\")." +
+            JavaVersionHelper.java7CompatibilityMessage(context.getJavaVersion()));
       }
     }
   }

java-checks/src/main/java/org/sonar/java/checks/FileCreateTempFileCheck.java

@@ -129,7 +129,11 @@ public void visitMethodInvocation(MethodInvocationTree mit) {
     if (FILE_DELETE.matches(mit)) {
       checkAndAdvanceState(mit, State.CREATE_TMP_FILE, State.DELETE);
     } else if (FILE_MKDIR.matches(mit) && State.MKDIR.equals(checkAndAdvanceState(mit, State.DELETE, State.MKDIR))) {
-      context.addIssue(mit, this, "Use \"Files.createTempDirectory\" or a library function to create this directory instead.");
+      context.addIssue(
+        mit,
+        this,
+        "Use \"Files.createTempDirectory\" or a library function to create this directory instead." +
+          JavaVersionHelper.java7CompatibilityMessage(context.getJavaVersion()));
     }
   }
 

java-checks/src/main/java/org/sonar/java/checks/LambdaOptionalParenthesisCheck.java

@@ -63,7 +63,7 @@ public void visitNode(Tree tree) {
       VariableTree param = let.parameters().get(0);
       String ident = param.simpleName().name();
       if(param.type().is(Tree.Kind.INFERED_TYPE)) {
-        addIssue(param, "Remove the parentheses around the \"" + ident + "\" parameter");
+        addIssue(param, "Remove the parentheses around the \"" + ident + "\" parameter" + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
       }
     }
   }

java-checks/src/main/java/org/sonar/java/checks/LambdaSingleExpressionCheck.java

@@ -67,7 +67,7 @@ public void visitNode(Tree tree) {
       if (singleStatementIsReturn(lambdaExpressionTree)) {
         message += " and then remove useless return keyword";
       }
-      addIssue(lambdaExpressionTree.body(), message);
+      addIssue(lambdaExpressionTree.body(), message + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
     }
   }
 

java-checks/src/main/java/org/sonar/java/checks/RepeatAnnotationCheck.java

@@ -39,6 +39,7 @@
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
 
 import javax.annotation.Nullable;
+
 import java.util.List;
 
 @Rule(
@@ -55,7 +56,7 @@ public class RepeatAnnotationCheck extends BaseTreeVisitor implements JavaFileSc
 
   @Override
   public boolean isCompatibleWithJavaVersion(@Nullable Integer version) {
-    return JavaVersionHelper.java8Guaranteed(version);
+    return JavaVersionHelper.java8Compatible(version);
   }
 
   @Override
@@ -69,7 +70,10 @@ public void visitAnnotation(AnnotationTree annotationTree) {
     if (isArrayInitialized(annotationTree)) {
       NewArrayTree arrayTree = (NewArrayTree) annotationTree.arguments().get(0);
       if (isAllSameAnnotation(arrayTree.initializers()) && isAnnotationRepeatable(arrayTree.initializers().get(0))) {
-        context.addIssue(annotationTree, this, "Remove the '" + getAnnotationName(annotationTree) + "' wrapper from this annotation group");
+        context.addIssue(
+          annotationTree,
+          this,
+          "Remove the '" + getAnnotationName(annotationTree) + "' wrapper from this annotation group" + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
       }
     }
     super.visitAnnotation(annotationTree);

java-checks/src/main/java/org/sonar/java/checks/ReplaceLambdaByMethodRefCheck.java

@@ -71,7 +71,7 @@ public void scanFile(JavaFileScannerContext context) {
   @Override
   public void visitLambdaExpression(LambdaExpressionTree tree) {
     if (isSingleMethodInvocationUsingLambdaParamAsArg(tree) || isBlockInvokingMethod(tree.body())) {
-      context.addIssue(tree, this, "Replace this lambda with a method reference.");
+      context.addIssue(tree, this, "Replace this lambda with a method reference." + JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
     }
     super.visitLambdaExpression(tree);
   }

java-checks/src/main/java/org/sonar/java/checks/SAMAnnotatedCheck.java

@@ -58,20 +58,20 @@
 public class SAMAnnotatedCheck extends IssuableSubscriptionVisitor implements JavaVersionAwareVisitor {
 
   private static final ImmutableMultimap<String, List<String>> OBJECT_METHODS = new ImmutableMultimap.Builder<String, List<String>>().
-      put("equals", ImmutableList.of("Object")).
-      put("getClass", ImmutableList.<String>of()).
-      put("hashcode", ImmutableList.<String>of()).
-      put("notify", ImmutableList.<String>of()).
-      put("notifyAll", ImmutableList.<String>of()).
-      put("toString", ImmutableList.<String>of()).
-      put("wait", ImmutableList.<String>of()).
-      put("wait", ImmutableList.of("long")).
-      put("wait", ImmutableList.of("long", "int")).
-      build();
+    put("equals", ImmutableList.of("Object")).
+    put("getClass", ImmutableList.<String>of()).
+    put("hashcode", ImmutableList.<String>of()).
+    put("notify", ImmutableList.<String>of()).
+    put("notifyAll", ImmutableList.<String>of()).
+    put("toString", ImmutableList.<String>of()).
+    put("wait", ImmutableList.<String>of()).
+    put("wait", ImmutableList.of("long")).
+    put("wait", ImmutableList.of("long", "int")).
+    build();
 
   @Override
   public boolean isCompatibleWithJavaVersion(Integer version) {
-    return JavaVersionHelper.java8Guaranteed(version);
+    return JavaVersionHelper.java8Compatible(version);
   }
 
   @Override
@@ -83,7 +83,10 @@ public List<Tree.Kind> nodesToVisit() {
   public void visitNode(Tree tree) {
     ClassTree classTree = (ClassTree) tree;
     if (hasOneAbstractMethod(classTree) && !isAnnotated(classTree)) {
-      addIssue(tree, "Annotate the \"" + classTree.simpleName().name() + "\" interface with the @FunctionInterface annotation");
+      addIssue(
+        tree,
+        "Annotate the \"" + classTree.simpleName().name() + "\" interface with the @FunctionInterface annotation" +
+          JavaVersionHelper.java8CompatibilityMessage(context.getJavaVersion()));
     }
   }