SONARJAVA-1382 Fix checks which should not add issues when having parsing issues

Author: Wohops

java-checks/src/main/java/org/sonar/java/checks/DefaultPackageCheck.java

@@ -41,7 +41,7 @@ public class DefaultPackageCheck implements JavaFileScanner {
 
   @Override
   public void scanFile(JavaFileScannerContext context) {
-    if (context.getTree().packageDeclaration() == null) {
+    if (context.fileParsed() && context.getTree().packageDeclaration() == null) {
       context.addIssueOnFile(this, "Move this file to a named package.");
     }
   }

java-checks/src/main/java/org/sonar/java/checks/EmptyFileCheck.java

@@ -40,9 +40,11 @@ public final class EmptyFileCheck implements JavaFileScanner {
 
   @Override
   public void scanFile(JavaFileScannerContext context) {
-    CompilationUnitTree tree = context.getTree();
-    if (tree.packageDeclaration() == null && tree.types().isEmpty()) {
-      context.addIssue(context.getTree(), this, "This Java file is empty.");
+    if (context.fileParsed()) {
+      CompilationUnitTree tree = context.getTree();
+      if (tree.packageDeclaration() == null && tree.types().isEmpty()) {
+        context.addIssue(context.getTree(), this, "This Java file is empty.");
+      }
     }
   }
 

java-checks/src/test/java/org/sonar/java/checks/DefaultPackageCheckTest.java

@@ -34,4 +34,9 @@ public void with_package() {
     JavaCheckVerifier.verifyNoIssue("src/test/files/checks/DefaultPackageCheck/WithPackage.java", new DefaultPackageCheck());
   }
 
+  @Test
+  public void test_parsing_error_file() {
+    JavaCheckVerifier.verifyNoIssue("src/test/files/checks/ParsingError.java", new DefaultPackageCheck());
+  }
+
 }

java-checks/src/test/java/org/sonar/java/checks/EmptyFileCheckTest.java

@@ -34,4 +34,9 @@ public void test_non_empty_file() {
     JavaCheckVerifier.verifyNoIssue("src/test/files/checks/NonEmptyFile.java", new EmptyFileCheck());
   }
 
+  @Test
+  public void test_parsing_error_file() {
+    JavaCheckVerifier.verifyNoIssue("src/test/files/checks/ParsingError.java", new EmptyFileCheck());
+  }
+
 }