Transitive relation exceeded should not fail the analysis

Author: benzonico

java-squid/src/main/java/org/sonar/java/se/SymbolicExecutionVisitor.java

@@ -23,6 +23,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.sonar.java.ast.visitors.SubscriptionVisitor;
+import org.sonar.java.se.symbolicvalues.BinaryRelation;
 import org.sonar.plugins.java.api.tree.Tree;
 
 import java.util.List;
@@ -39,7 +40,7 @@ public List<Tree.Kind> nodesToVisit() {
   public void visitNode(Tree tree) {
     try {
       tree.accept(new ExplodedGraphWalker(context));
-    } catch (ExplodedGraphWalker.MaximumStepsReachedException | ExplodedGraphWalker.ExplodedGraphTooBigException exception) {
+    } catch (ExplodedGraphWalker.MaximumStepsReachedException | ExplodedGraphWalker.ExplodedGraphTooBigException | BinaryRelation.TransitiveRelationExceededException exception) {
       LOG.debug("Could not complete symbolic execution: ", exception);
     }
 

java-squid/src/main/java/org/sonar/java/se/symbolicvalues/BinaryRelation.java

@@ -35,7 +35,11 @@
 
 public abstract class BinaryRelation {
 
-  static final String TRANSITIVE_RELATIONS_EXCEEDED = "Number of transitive relations exceeded!";
+  public class TransitiveRelationExceededException extends RuntimeException {
+    public TransitiveRelationExceededException() {
+      super("Number of transitive relations exceeded!");
+    }
+  }
 
   protected final Kind kind;
   protected final SymbolicValue leftOp;
@@ -93,7 +97,7 @@ protected RelationState resolveState(Collection<BinaryRelation> knownRelations,
       return RelationState.UNDETERMINED;
     }
     if (usedRelations.size() > 200) {
-      throw new IllegalStateException(TRANSITIVE_RELATIONS_EXCEEDED);
+      throw new TransitiveRelationExceededException();
     }
     for (BinaryRelation relation : knownRelations) {
       RelationState result = relation.implies(this);
@@ -210,7 +214,7 @@ protected BinaryRelation conjunction(BinaryRelation relation) {
   protected abstract BinaryRelation symmetric();
 
   /**
-   * @param a relation between symbolic values
+   * @param relation a relation between symbolic values
    * @return a RelationState<ul>
    * <li>FULFILLED  if the receiver implies that the supplied relation is true</li>
    * <li>UNFULFILLED if the receiver implies that the supplied relation is false</li>

java-squid/src/test/java/org/sonar/java/se/symbolicvalues/BinaryRelationsTest.java

@@ -512,8 +512,8 @@ public void checkTransitiveLimit() {
     try {
       relation(EQUAL, first, last).resolveState(relations);
       fail("Transitive limit was exceeded, but not detected!");
-    } catch (IllegalStateException e) {
-      assertThat(e.getMessage()).isEqualTo(BinaryRelation.TRANSITIVE_RELATIONS_EXCEEDED);
+    } catch (BinaryRelation.TransitiveRelationExceededException e) {
+      assertThat(e.getMessage()).contains("exceeded");
     }
   }