Skip to content

Commit 2294b19

Browse files
committed
Fix quality flaws
1 parent 37c9185 commit 2294b19

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

java-checks/src/main/java/org/sonar/java/checks/AbstractDeprecatedChecker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ private static boolean hasDeprecatedAnnotation(Iterable<AnnotationTree> annotati
8787
protected static Tree getReportTree(Tree tree) {
8888
Tree reportTree = tree;
8989
if(reportTree.is(PublicApiChecker.classKinds())) {
90-
reportTree = ExpressionsHelper.reportOnClassTree(((ClassTree) reportTree));
90+
reportTree = ExpressionsHelper.reportOnClassTree((ClassTree) reportTree);
9191
} else if(reportTree.is(PublicApiChecker.methodKinds())) {
9292
reportTree = ((MethodTree) reportTree).simpleName();
9393
} else if(reportTree.is(Tree.Kind.VARIABLE)) {

java-checks/src/main/java/org/sonar/java/checks/IndentationCheck.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.sonar.check.Priority;
2626
import org.sonar.check.Rule;
2727
import org.sonar.check.RuleProperty;
28+
import org.sonar.java.model.JavaTree;
2829
import org.sonar.java.syntaxtoken.FirstSyntaxTokenFinder;
2930
import org.sonar.java.syntaxtoken.LastSyntaxTokenFinder;
3031
import org.sonar.java.tag.Tag;
@@ -199,7 +200,7 @@ private void checkIndentation(List<? extends Tree> trees) {
199200
private void checkIndentation(Tree tree, int expectedLevel) {
200201
SyntaxToken firstSyntaxToken = FirstSyntaxTokenFinder.firstSyntaxToken(tree);
201202
if (firstSyntaxToken.column() != expectedLevel && !isExcluded(tree, firstSyntaxToken.line())) {
202-
addIssue(tree, "Make this line start at column " + (expectedLevel + 1) + ".");
203+
addIssue(((JavaTree) tree).getLine(), "Make this line start at column " + (expectedLevel + 1) + ".");
203204
isBlockAlreadyReported = true;
204205
}
205206
lastCheckedLine = LastSyntaxTokenFinder.lastSyntaxToken(tree).line();

java-checks/src/test/files/checks/IndentationCheck_default.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,3 +192,10 @@ protected void append(final ILoggingEvent event) {
192192
}
193193

194194
}
195+
196+
public interface plop {
197+
@Foo
198+
public static class Inner { // Noncompliant
199+
public static final String FOO = "foo";
200+
}
201+
}

0 commit comments

Comments
 (0)