SONARJAVA-5304 Improve issue message in case of array type cast in S6201 (#5019)

Author: romainbrenguier

java-checks-test-sources/default/src/main/java/checks/InstanceOfPatternMatching.java

@@ -4,6 +4,20 @@
 
 public abstract class InstanceOfPatternMatching {
 
+  private static String booleanArray(Object o){
+    if(o instanceof boolean[]){ // Noncompliant {{Replace this instanceof check and cast with 'instanceof boolean[] booleanArray'}}
+      return Boolean.toString(((boolean[])o)[0]);
+    }
+    return "not a boolean array";
+  }
+
+  private static String booleanArray2(Object o){
+    if(o instanceof boolean[][]){ // Noncompliant {{Replace this instanceof check and cast with 'instanceof boolean[][] booleanArrayArray'}}
+      return Boolean.toString(((boolean[][])o)[0][0]);
+    }
+    return "not a boolean array";
+  }
+
   int if1(Object o) {
     if (o instanceof String) { // Noncompliant {{Replace this instanceof check and cast with 'instanceof String str'}}
 //      ^^^^^^^^^^^^^^^^^^^

java-checks/src/main/java/org/sonar/java/checks/InstanceOfPatternMatchingCheck.java

@@ -171,7 +171,8 @@ public void visitTypeCast(TypeCastTree tree) {
       Type type = tree.symbolType();
       if (!type.isUnknown() && type.equals(instanceOf.type().symbolType())
         && SyntacticEquivalence.areEquivalentIncludingSameVariables(tree.expression(), instanceOf.expression())) {
-        report(instanceOf, tree, tree.type().symbolType().name().toLowerCase(Locale.ROOT));
+        Type symbolType = tree.type().symbolType();
+        report(instanceOf, tree, makeVariableNameForType(symbolType));
       }
     }
 
@@ -182,4 +183,8 @@ private void report(InstanceOfTree instanceOf, ExpressionTree cast, String name)
       reportIssue(instanceOf, message, Collections.singletonList(secondary), null);
     }
   }
+
+  private static String makeVariableNameForType(Type type) {
+    return type.name().toLowerCase(Locale.ROOT).replace("[]", "Array");
+  }
 }