-minor refactor

-now read/write operation are allowed while browsing

Author: simon

app/build.gradle

@@ -1,13 +1,13 @@
 apply plugin: 'com.android.application'
 
 android {
-    compileSdkVersion 27
+    compileSdkVersion 28
     defaultConfig {
         applicationId "org.twistedappdeveloper.opcclient"
-        minSdkVersion 15
-        targetSdkVersion 27
-        versionCode 10
-        versionName "1.0.7.1"
+        minSdkVersion 17
+        targetSdkVersion 28
+        versionCode 11
+        versionName "1.0.7.2"
         multiDexEnabled true
     }
     buildTypes {
@@ -40,6 +40,7 @@ dependencies {
     implementation files('libs/httpcore-nio-4.4.4.jar')
     implementation files('libs/httpclient-4.5.2.jar')
     implementation files('libs/opc.jar')
-    implementation 'com.android.support:appcompat-v7:27.1.1'
-    implementation 'com.android.support.constraint:constraint-layout:1.1.1'
+    implementation 'com.android.support:appcompat-v7:28.0.0'
+    implementation 'com.android.support.constraint:constraint-layout:1.1.3'
+    implementation 'pl.droidsonroids.gif:android-gif-drawable:1.2.17'
 }

app/src/main/AndroidManifest.xml

@@ -26,7 +26,7 @@
             android:name=".SessionActivity"
             android:screenOrientation="portrait" />
         <activity
-            android:name=".SelectSession_Activity"
+            android:name=".SelectSessionActivity"
             android:screenOrientation="portrait" />
         <activity
             android:name=".ListSubscriptionActivity"

app/src/main/java/OpcUtils/BackListener.java

@@ -5,18 +5,18 @@
 
 public class BackListener implements FragmentManager.OnBackStackChangedListener {
 
-    int prec_size;
-    FragmentManager fm;
+    private int prec_size;
+    private FragmentManager fm;
 
     public BackListener(FragmentManager fm) {
         this.fm = fm;
-        prec_size=0;
+        prec_size = 0;
     }
 
     @Override
     public void onBackStackChanged() {
-        if(fm.getBackStackEntryCount()<prec_size)
+        if (fm.getBackStackEntryCount() < prec_size)
             ManagerOPC.getIstance().pop();
-        prec_size=fm.getBackStackEntryCount();
+        prec_size = fm.getBackStackEntryCount();
     }
 }

app/src/main/java/OpcUtils/ConnectionThread/ThreadBrowse.java

@@ -10,41 +10,41 @@
 
 public class ThreadBrowse extends Thread {
 
-    Handler handler;
-    int session_position;
-    int position;
-    boolean sent=false;
-
-    public ThreadBrowse(int session_position,int position){
-        this.session_position=session_position;
-        this.position=position;
+    private Handler handler;
+    private int session_position;
+    private int position;
+    private boolean sent = false;
+
+    public ThreadBrowse(int session_position, int position) {
+        this.session_position = session_position;
+        this.position = position;
     }
 
-    private synchronized void send(Message msg){
-        if(!sent) {
+    private synchronized void send(Message msg) {
+        if (!sent) {
             msg.sendToTarget();
-            sent =true;
+            sent = true;
         }
     }
 
     public void start(Handler handler) {
         super.start();
-        this.handler=handler;
+        this.handler = handler;
     }
 
     @Override
     public void run() {
         super.run();
         try {
-            Thread t= new Thread(new Runnable() {
+            Thread t = new Thread(new Runnable() {
                 @Override
                 public void run() {
                     try {
                         BrowseResponse res;
-                        res=ManagerOPC.getIstance().Browse(position,session_position);
-                        send(handler.obtainMessage(0,res));
+                        res = ManagerOPC.getIstance().browseOperation(position, session_position);
+                        send(handler.obtainMessage(0, res));
                     } catch (ServiceResultException e) {
-                        send(handler.obtainMessage(-1,e.getStatusCode()));
+                        send(handler.obtainMessage(-1, e.getStatusCode()));
                     }
                 }
             });

app/src/main/java/OpcUtils/ConnectionThread/ThreadCreateMonitoredItem.java

@@ -11,11 +11,11 @@
 
 public class ThreadCreateMonitoredItem extends Thread {
 
-    Handler handler;
-    SubscriptionElement subElement;
-    CreateMonitoredItemsRequest request;
-    int position =-1;
-    boolean sent =false;
+    private Handler handler;
+    private SubscriptionElement subElement;
+    private CreateMonitoredItemsRequest request;
+    private int position =-1;
+    private boolean sent =false;
 
     public ThreadCreateMonitoredItem(SubscriptionElement subElement, CreateMonitoredItemsRequest request){
         this.subElement=subElement;

app/src/main/java/OpcUtils/ConnectionThread/ThreadCreateSession.java

@@ -10,12 +10,12 @@
 
 public class ThreadCreateSession extends Thread {
 
-    Handler handler;
-    ManagerOPC gestore;
-    EndpointDescription endpointDescription;
-    String url;
-    int position =-1;
-    boolean sent =false;
+    private Handler handler;
+    private ManagerOPC gestore;
+    private EndpointDescription endpointDescription;
+    private String url;
+    private int position =-1;
+    private boolean sent =false;
 
     public ThreadCreateSession(ManagerOPC gestore, String url, EndpointDescription endpointDescription){
         this.gestore=gestore;

app/src/main/java/OpcUtils/ConnectionThread/ThreadCreateSubscription.java

@@ -10,11 +10,11 @@
 
 public class ThreadCreateSubscription extends Thread {
 
-    Handler handler;
-    SessionElement session;
-    CreateSubscriptionRequest request;
-    int position =-1;
-    boolean sent =false;
+    private Handler handler;
+    private SessionElement session;
+    private CreateSubscriptionRequest request;
+    private int position =-1;
+    private boolean sent =false;
 
     public ThreadCreateSubscription(SessionElement session, CreateSubscriptionRequest request){
         this.session=session;

app/src/main/java/OpcUtils/ConnectionThread/ThreadDeleteSubscription.java

@@ -9,10 +9,10 @@
 
 public class ThreadDeleteSubscription extends Thread {
 
-    Handler handler;
-    SessionChannel session;
-    UnsignedInteger subid;
-    boolean sent =false;
+    private Handler handler;
+    private SessionChannel session;
+    private UnsignedInteger subid;
+    private boolean sent =false;
 
     public ThreadDeleteSubscription(SessionChannel session, UnsignedInteger subid){
         this.session=session;

app/src/main/java/OpcUtils/ConnectionThread/ThreadDiscoveryEndpoints.java

@@ -9,10 +9,10 @@
 
 public class ThreadDiscoveryEndpoints extends Thread {
 
-    Handler handler;
-    String url;
-    Client client;
-    boolean sent =false;
+    private Handler handler;
+    private String url;
+    private Client client;
+    private boolean sent =false;
     public ThreadDiscoveryEndpoints(Client client, String url){
         this.url=url;
         this.client=client;

app/src/main/java/OpcUtils/ConnectionThread/ThreadPublish.java

@@ -14,7 +14,7 @@
 
 public class ThreadPublish extends Thread {
 
-    SessionElement sessionElement;
+    private SessionElement sessionElement;
     public ThreadPublish(SessionElement sessionElement) {
         this.sessionElement = sessionElement;
     }