traversal: remove dead bfs/ and navigation/ modules, move Distance to dist

- Add pub type Distance = f32 to traversal/dist/adjacency.rs (alongside Neighbor).
- Update all 9 HNSW files + coordinator to use traversal::dist::Distance.
- Remove traversal::bfs (superseded by expand/ + search/).
- Remove traversal::navigation (NavigationEngine/Service/Coordinator/Worker
  never instantiated; App::to_task() was unimplemented; only Distance was
  actually used externally).
- Remove navigation re-export from traversal/search/mod.rs.
- Strip job/mod.rs of navigation-only types (App, Job, JobReport, JobStatus,
  CollectiveResult, initialize_job_run); keep only JobId and logger.
- Delete unused job/service.rs (JobService had no callers).

Made-with: Cursor

Author: shisoft

src/apps/hnsw/coordinator/mod.rs

@@ -16,7 +16,7 @@ use futures::future::BoxFuture;
 use itertools::Itertools;
 use neb::{index::vector::HnswConfig, query::data_client::IndexedDataClient, ram::types::RandValue};
 
-use crate::{graph::GraphEngine, job::JobId, traversal::navigation::Distance};
+use crate::{graph::GraphEngine, job::JobId, traversal::dist::Distance};
 
 use super::{
     measurements::MetricEncoding,

src/apps/hnsw/coordinator/tests.rs

@@ -17,7 +17,7 @@ use crate::apps::hnsw::HNSWPartitionService;
 use crate::job::logger::JobLogger;
 use crate::server::MorpheusServer;
 use crate::tests::start_server;
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 
 const CELL_SCHEMA_ID: u32 = hash_ident!("CELL");
 const VECTOR: &str = "VECTOR";

src/apps/hnsw/measurements.rs

@@ -4,7 +4,7 @@ use std::fmt::Debug;
 
 use super::simd_ops; // Used by metric_distance functions
 
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 
 pub use neb::index::vector::MetricEncoding;
 

src/apps/hnsw/partition/search.rs

@@ -32,7 +32,7 @@ use crate::{
         JobId,
     },
     job_log_debug, job_log_trace, job_log_verbose,
-    traversal::navigation::Distance,
+    traversal::dist::Distance,
     utils::ring_buffer::RingBuffer,
 };
 use log::info;

src/apps/hnsw/partition/service.rs

@@ -21,7 +21,7 @@ use crate::{
         logger::{append_job_log, JobLogLevel, JobLogger},
         JobId,
     },
-    traversal::navigation::Distance,
+    traversal::dist::Distance,
 };
 use neb::index::vector::HnswConfig;
 

src/apps/hnsw/partition/tests.rs

@@ -18,7 +18,7 @@ use crate::job::logger::JobLogger;
 use crate::job::JobId;
 use crate::server::MorpheusServer;
 use crate::tests::start_server;
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 use dovahkiin::types::Map as DovMap;
 use tokio::sync::Semaphore;
 

src/apps/hnsw/partition/types.rs

@@ -11,7 +11,7 @@ use neb::ram::cell::ReadError;
 use neb::{client::transaction::TxnError, ram::cell::WriteError};
 
 use crate::graph::{edge::EdgeError, NeighbourhoodError};
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 use crate::utils::ring_buffer::RingBuffer;
 
 /// A fast hasher for Id types that uses XOR of the two u64 fields.

src/apps/hnsw/partition/utils.rs

@@ -1,6 +1,6 @@
 use crate::apps::hnsw::partition::types::HNSWIndexError;
 use crate::graph::partitioner::vector::FromVectorPartitioner;
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 use crate::utils::ring_buffer::RingBuffer;
 use dovahkiin::types::Id;
 use neb::ram::cell::OwnedCell;

src/apps/hnsw/recovery_tests.rs

@@ -28,7 +28,7 @@ use crate::apps::hnsw::partition::schema::{
 use crate::apps::hnsw::HNSWPartitionService;
 use crate::server::MorpheusServer;
 use crate::tests::start_server_with_storage_and_recovery;
-use crate::traversal::navigation::Distance;
+use crate::traversal::dist::Distance;
 
 const CELL_SCHEMA_ID: u32 = hash_ident!("RECOVERY_TEST_CELL");
 const VECTOR: &str = "VECTOR";

src/job/mod.rs

@@ -1,68 +1,13 @@
-use crate::traversal::navigation::App;
-use dovahkiin::types::Id;
-use parking_lot::Mutex;
 use serde::{Deserialize, Serialize};
-use std::sync::Arc;
 
 pub mod logger;
-pub mod service;
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
 pub struct JobId {
     pub coordinator_server_id: u64,
     pub coordinator_job_id: u64,
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub struct JobReport {
-    pub status: JobStatus,
-    pub result: Vec<u8>,
-}
-
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
-pub enum JobStatus {
-    Created,
-    Initialized,
-    Running,
-    Finished,
-    Failed,
-}
-
-pub struct Job {
-    pub job_id: JobId,
-    pub app: App,
-    pub config: Vec<u8>,
-    pub report: Arc<Mutex<JobReport>>,
-}
-
-pub enum CollectiveResult {
-    Found(Vec<(Id, u64)>),
-    Continue(Vec<(Id, u64, f32)>),
-    Error(Vec<(Id, u64, String)>),
-    NotFound,
-}
-
-impl JobReport {
-    pub fn new() -> Self {
-        Self {
-            status: JobStatus::Created,
-            result: vec![],
-        }
-    }
-
-    pub fn update_status(&mut self, status: JobStatus) {
-        self.status = status;
-    }
-
-    pub fn update_findings(&mut self, findings: Vec<u8>) {
-        self.result = findings;
-    }
-}
-
-pub fn initialize_job_run(report: &Arc<Mutex<JobReport>>) {
-    report.lock().update_status(JobStatus::Running);
-}
-
 impl JobId {
     pub fn new(coordinator_server_id: u64, coordinator_job_id: u64) -> Self {
         Self {