Skip to content
This repository was archived by the owner on Jan 26, 2026. It is now read-only.

Commit e816256

Browse files
committed
config: Do not parse unsupported ControlPath/ControlMaster
Signed-off-by: Jakub Jelen <jjelen@redhat.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org> (cherry picked from commit 82b363f294dc318c9a20ffcbfe16dfa3e082cfed)
1 parent 960a6d1 commit e816256

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/config.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ static struct ssh_config_keyword_table_s ssh_config_keyword_table[] = {
132132
{ "verifyhostkeydns", SOC_UNSUPPORTED},
133133
{ "visualhostkey", SOC_UNSUPPORTED},
134134
{ "clearallforwardings", SOC_NA},
135-
{ "controlmaster", SOC_CONTROLMASTER},
135+
{ "controlmaster", SOC_NA},
136136
{ "controlpersist", SOC_NA},
137-
{ "controlpath", SOC_CONTROLPATH},
137+
{ "controlpath", SOC_NA},
138138
{ "dynamicforward", SOC_NA},
139139
{ "escapechar", SOC_NA},
140140
{ "exitonforwardfailure", SOC_NA},

tests/unittests/torture_config.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1404,7 +1404,7 @@ static void torture_config_control_path(void **state,
14041404
torture_reset_config(session);
14051405
ssh_options_set(session, SSH_OPTIONS_HOST, "simple");
14061406
_parse_config(session, file, string, SSH_OK);
1407-
assert_string_equal(session->opts.control_path, "/tmp/ssh-%r@%h:%p");
1407+
assert_null(session->opts.control_path);
14081408

14091409
torture_reset_config(session);
14101410
ssh_options_set(session, SSH_OPTIONS_HOST, "none");
@@ -1439,12 +1439,12 @@ static void torture_config_control_master(void **state,
14391439
torture_reset_config(session);
14401440
ssh_options_set(session, SSH_OPTIONS_HOST, "simple");
14411441
_parse_config(session, file, string, SSH_OK);
1442-
assert_int_equal(session->opts.control_master, SSH_CONTROL_MASTER_AUTO);
1442+
assert_int_equal(session->opts.control_master, SSH_CONTROL_MASTER_NO);
14431443

14441444
torture_reset_config(session);
14451445
ssh_options_set(session, SSH_OPTIONS_HOST, "none");
14461446
_parse_config(session, file, string, SSH_OK);
1447-
assert_int_equal(session->opts.control_master, SSH_CONTROL_MASTER_YES);
1447+
assert_int_equal(session->opts.control_master, SSH_CONTROL_MASTER_NO);
14481448
}
14491449

14501450
/**

tests/unittests/torture_options.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1350,7 +1350,7 @@ static void torture_options_copy(void **state)
13501350
assert_string_equal(session->opts.pubkey_accepted_types,
13511351
new->opts.pubkey_accepted_types);
13521352
assert_string_equal(session->opts.ProxyCommand, new->opts.ProxyCommand);
1353-
assert_string_equal(session->opts.control_path, new->opts.control_path);
1353+
assert_null(new->opts.control_path);
13541354
/* TODO custombanner */
13551355
assert_int_equal(session->opts.timeout, new->opts.timeout);
13561356
assert_int_equal(session->opts.timeout_usec, new->opts.timeout_usec);

0 commit comments

Comments
 (0)